Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quick settings tile for Android N #114

Merged
merged 1 commit into from Dec 23, 2017

Conversation

ashutoshgngwr
Copy link
Contributor

@ashutoshgngwr ashutoshgngwr commented Dec 21, 2017

screenshot_20171221-224435
screenshot_20171221-224440

@ppareit ppareit merged commit bced031 into ppareit:master Dec 23, 2017
@ppareit
Copy link
Owner

ppareit commented Dec 23, 2017

Love the simplicity in which you implemented this. Just change the manifest and add the class with the correct logic. Great!

@ashutoshgngwr
Copy link
Contributor Author

I did what the official docs pointed out. I didn't understand what do you mean by correct logic. Please clarify!

@ppareit
Copy link
Owner

ppareit commented Dec 23, 2017

Using the actions from the FsService to start/stop the server using a broadcast and not directly calling startservice..

@ashutoshgngwr
Copy link
Contributor Author

That's what it already does! Am I doing it wrong?

...
public class FsTileService extends TileService {

    @Override
    public void onClick() {
        if(getQsTile().getState() == Tile.STATE_INACTIVE)
            sendBroadcast(new Intent(FsService.ACTION_START_FTPSERVER));
        else if(getQsTile().getState() == Tile.STATE_ACTIVE)
            sendBroadcast(new Intent(FsService.ACTION_STOP_FTPSERVER));
    }
...

@ppareit
Copy link
Owner

ppareit commented Dec 23, 2017 via email

@ashutoshgngwr
Copy link
Contributor Author

Oh sorry! I misunderstood.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants