Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a potential member, I want to be able to pay with my credit card so I can become a paid member #4

Closed
fleur94 opened this issue Dec 15, 2015 · 7 comments
Assignees

Comments

@fleur94
Copy link

fleur94 commented Dec 15, 2015

Payment processing with stripe

Requirement from Brendan:

  • once the payment amount and type is decided, generate a pending invoice.
  • If the payment failed, update the invoice with pending status, and let the user try again. He prefer to not have any 'rejected' state.
  • If the payment success, update the invoice with paid status.
  • presumably, the state before the payment is attempted is considered pending

Payment Process changes:

  • InvoiceController need to remove some useless render, and this raise an issue of error code define. As Create Invoice is happened after charge card, we need to figure out what kind of error message and http code corresponding to different cases. CHECKED
  • Payment Validation: we need to add both front end and bank end validation for the amount, to let it anytime not blank and anytime no less than 1. CHECKED
  • New design imported, If the user click "I don't want to contribute", then we need to hide the whole membership contribute section, and process the user to the next stage. We still need to create a stub invoice for it. CHECKED
  • Remove Go back button on the payment page. CHECKED
@akjones akjones changed the title Design & Initial Usability Testing for Form Front-End As a potential member, I want to be able to pay with my credit card Dec 17, 2015
@akjones akjones changed the title As a potential member, I want to be able to pay with my credit card As a potential member, I want to be able to pay with my credit card so I can become a paid member Dec 17, 2015
@issy-li issy-li self-assigned this Jan 10, 2016
@akjones
Copy link
Contributor

akjones commented Jan 10, 2016

i think we'll probably end up using this feature: https://stripe.com/docs/checkout

@akjones akjones assigned Doddzy and unassigned issy-li Jan 13, 2016
@akjones
Copy link
Contributor

akjones commented Jan 17, 2016

Credit card: features basically done, but finish the UI. Get npm install to work. Test has been added for payment, should be done once Claire commits and merges with Issy.

@Doddzy Doddzy removed their assignment Jan 19, 2016
@Doddzy
Copy link

Doddzy commented Jan 19, 2016

All ready, just need api keys

@akjones
Copy link
Contributor

akjones commented Jan 20, 2016

api keys have been loaded

@akjones
Copy link
Contributor

akjones commented Jan 20, 2016

are we putting any testing in the payment react component ?- there's a lot of code in there that doesn't have tests...

@Doddzy Doddzy self-assigned this Jan 20, 2016
@akjones
Copy link
Contributor

akjones commented Jan 20, 2016

as part of this card, could we please tidy up the dead code relating to payments? particular any http responses that render templates

@Doddzy
Copy link

Doddzy commented Jan 21, 2016

Ready for testing

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants