-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop compatiblity with Python 3.6 #190
Conversation
I noticed a disadvantage while updating the CI config: PyPy3 recently had a stable release, but it still only supports Python 3.6.9, so we would be dropping PyPy support (until they move to Py3.7). I don't think this is a major issue, as ppb itself doesn't support PyPy. |
Not at this time, but I'd be ok pursuing pypy compatibility for performance reasons? There's other complications, though. If the dataclasses bugs cause problems, let's drop it from ppb-vector; we're only using it for utility reasons. |
To be clear, that's not a bug in the stdlib's The issue is that the (unofficial) PyPI package is essentially a snapshot from an early development version of |
bors r+ |
190: Drop compatiblity with Python 3.6 r=astronouth7303 a=nbraud We only aim to support the last 2 major versions of Python (currently 3.7 and 3.8), and the `dataclasses` backport for Python 3.6 is unmaintained and broken (see discussion in #184). This should allow us to unblock #168 Co-authored-by: Nicolas Braud-Santoni <nicolas@braud-santoni.eu>
Build failed
|
bors r=astraluma |
190: Drop compatiblity with Python 3.6 r=astraluma a=nbraud We only aim to support the last 2 major versions of Python (currently 3.7 and 3.8), and the `dataclasses` backport for Python 3.6 is unmaintained and broken (see discussion in #184). This should allow us to unblock #168 Co-authored-by: Nicolas Braud-Santoni <nicolas@braud-santoni.eu>
Build failed: |
bors r=astraluma |
190: Drop compatiblity with Python 3.6 r=astraluma a=nbraud We only aim to support the last 2 major versions of Python (currently 3.7 and 3.8), and the `dataclasses` backport for Python 3.6 is unmaintained and broken (see discussion in #184). This should allow us to unblock #168 Co-authored-by: Nicolas Braud-Santoni <nicolas@braud-santoni.eu> Co-authored-by: Jamie Bliss <jamie@ivyleav.es>
Build failed: |
OK, I guess I'm making a CI-fixing PR first >_>' |
bors r=astraluma |
We only aim to support the last 2 major versions of Python (currently 3.7 and 3.8), and the
dataclasses
backport for Python 3.6 is unmaintained and broken (see discussion in #184).This should allow us to unblock #168