Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop compatiblity with Python 3.6 #190

Merged
merged 2 commits into from
Oct 23, 2021
Merged

Drop compatiblity with Python 3.6 #190

merged 2 commits into from
Oct 23, 2021

Conversation

nbraud
Copy link
Collaborator

@nbraud nbraud commented Nov 14, 2019

We only aim to support the last 2 major versions of Python (currently 3.7 and 3.8), and the dataclasses backport for Python 3.6 is unmaintained and broken (see discussion in #184).

This should allow us to unblock #168

@nbraud
Copy link
Collaborator Author

nbraud commented Nov 14, 2019

I noticed a disadvantage while updating the CI config: PyPy3 recently had a stable release, but it still only supports Python 3.6.9, so we would be dropping PyPy support (until they move to Py3.7).

I don't think this is a major issue, as ppb itself doesn't support PyPy.

@AstraLuma
Copy link
Member

Not at this time, but I'd be ok pursuing pypy compatibility for performance reasons? There's other complications, though.

If the dataclasses bugs cause problems, let's drop it from ppb-vector; we're only using it for utility reasons.

@nbraud
Copy link
Collaborator Author

nbraud commented Dec 11, 2019

If the dataclasses bugs cause problems

To be clear, that's not a bug in the stdlib's dataclasses module (at least, not as found in any version of Python ever released).

The issue is that the (unofficial) PyPI package is essentially a snapshot from an early development version of dataclasses from before it was first included in a stable Python release.

@AstraLuma
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Dec 19, 2019
190: Drop compatiblity with Python 3.6 r=astronouth7303 a=nbraud

We only aim to support the last 2 major versions of Python (currently 3.7 and 3.8), and the `dataclasses` backport for Python 3.6 is unmaintained and broken (see discussion in #184).

This should allow us to unblock #168 

Co-authored-by: Nicolas Braud-Santoni <nicolas@braud-santoni.eu>
@bors
Copy link
Contributor

bors bot commented Dec 19, 2019

Build failed

  • Linux python:3.7-slim
  • Linux python:3.8-slim
  • macOS PYTHON:3.7.5
  • macOS PYTHON:3.8.0
  • Windows python:3.7-windowsservercore-1809

@nbraud
Copy link
Collaborator Author

nbraud commented Oct 23, 2021

bors r=astraluma

bors bot added a commit that referenced this pull request Oct 23, 2021
190: Drop compatiblity with Python 3.6 r=astraluma a=nbraud

We only aim to support the last 2 major versions of Python (currently 3.7 and 3.8), and the `dataclasses` backport for Python 3.6 is unmaintained and broken (see discussion in #184).

This should allow us to unblock #168 

Co-authored-by: Nicolas Braud-Santoni <nicolas@braud-santoni.eu>
@bors
Copy link
Contributor

bors bot commented Oct 23, 2021

Build failed:

@nbraud
Copy link
Collaborator Author

nbraud commented Oct 23, 2021

bors r=astraluma

bors bot added a commit that referenced this pull request Oct 23, 2021
190: Drop compatiblity with Python 3.6 r=astraluma a=nbraud

We only aim to support the last 2 major versions of Python (currently 3.7 and 3.8), and the `dataclasses` backport for Python 3.6 is unmaintained and broken (see discussion in #184).

This should allow us to unblock #168 

Co-authored-by: Nicolas Braud-Santoni <nicolas@braud-santoni.eu>
Co-authored-by: Jamie Bliss <jamie@ivyleav.es>
@bors
Copy link
Contributor

bors bot commented Oct 23, 2021

Build failed:

@nbraud
Copy link
Collaborator Author

nbraud commented Oct 23, 2021

OK, I guess I'm making a CI-fixing PR first >_>'

@nbraud
Copy link
Collaborator Author

nbraud commented Oct 23, 2021

bors r=astraluma

@bors bors bot merged commit 41e447a into ppb:canon Oct 23, 2021
@nbraud nbraud deleted the drop-py3.6 branch October 23, 2021 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants