Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a blessed way to handle deprecations. #618

Merged
merged 2 commits into from
May 17, 2021
Merged

Add a blessed way to handle deprecations. #618

merged 2 commits into from
May 17, 2021

Conversation

AstraLuma
Copy link
Member

Closes #601

@AstraLuma AstraLuma marked this pull request as ready for review May 17, 2021 18:42
@AstraLuma AstraLuma requested a review from a team as a code owner May 17, 2021 18:42
pathunstrom
pathunstrom approved these changes May 17, 2021
View reviewed changes
Copy link
Collaborator

@pathunstrom pathunstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request May 17, 2021
@bors @ironfroggy @AstraLuma
Merge #484 #618
02ee683 
484: Implement sprite flipping. r=pathunstrom a=ironfroggy



618: Add a blessed way to handle deprecations. r=pathunstrom a=AstraLuma

Closes #601

Co-authored-by: Calvin Spealman <ironfroggy@gmail.com>
Co-authored-by: Jamie Bliss <jamie@ivyleav.es>
@bors
Copy link
Contributor

bors bot commented May 17, 2021

Build failed (retrying...):

bors bot added a commit that referenced this pull request May 17, 2021
@bors @AstraLuma
Merge #618
0d0b63a 
618: Add a blessed way to handle deprecations. r=pathunstrom a=AstraLuma

Closes #601

Co-authored-by: Jamie Bliss <jamie@ivyleav.es>
@pathunstrom
Copy link
Collaborator

bors try

bors bot added a commit that referenced this pull request May 17, 2021
@bors
Try #618:
0a48b4d
@bors
Copy link
Contributor

bors bot commented May 17, 2021

Build failed:

@bors
Copy link
Contributor

bors bot commented May 17, 2021

try

Build failed:

@pathunstrom
Copy link
Collaborator

bors retry

bors bot added a commit that referenced this pull request May 17, 2021
@bors
Try #618:
8a56606
@bors
Copy link
Contributor

bors bot commented May 17, 2021

try

Build succeeded:

@pathunstrom
Copy link
Collaborator

bors r+

@bors
Copy link
Contributor

bors bot commented May 17, 2021

Build succeeded:

@bors bors bot merged commit 4833d32 into ppb:canon May 17, 2021
@AstraLuma AstraLuma deleted the deprecations branch May 18, 2021 16:34
@AstraLuma AstraLuma mentioned this pull request Oct 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pathunstrom pathunstrom pathunstrom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better deprecation system
2 participants
@AstraLuma @pathunstrom