Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sdlinfo tool #628

Merged
merged 10 commits into from
Nov 1, 2021
Merged

Add sdlinfo tool #628

merged 10 commits into from
Nov 1, 2021

Conversation

AstraLuma
Copy link
Member

Add a little tool that'll examine SDL and hopefully help track down any kind of "missing feature" problems.

@AstraLuma AstraLuma requested a review from a team as a code owner May 18, 2021 20:37
@AstraLuma AstraLuma marked this pull request as draft May 18, 2021 20:37
@AstraLuma AstraLuma marked this pull request as ready for review May 18, 2021 21:43
@AstraLuma
Copy link
Member Author

AstraLuma commented May 18, 2021

Things that aren't included:

  • Audio device names
  • Game controllers (as distinct from joysticks)
  • Sensors
  • Displays
  • Touch devices
  • WHEEL data from pysdl2-dll

@pathunstrom
Copy link
Collaborator

Real question, how testable are these routines in CI?

@AstraLuma
Copy link
Member Author

Piper, asking the hard questions.

In theory, this was written in a pretty testable way and we should be able to check their output pretty easily.

But I have no idea how SDL2 behaves in a container on a headless server.

@pathunstrom
Copy link
Collaborator

Yup, that's my biggest concern. I feel like "no throwing an error" is all I actually care about, since the output is not guaranteed to be the same across different CI environments.

@AstraLuma
Copy link
Member Author

At least some of the environment info is indicated in https://cirrus-ci.com/task/4754263726358528

@AstraLuma
Copy link
Member Author

@pathunstrom are those sufficient tests?

@AstraLuma
Copy link
Member Author

ugh, I think I need a real live mac to debug those errors.

Apparently haptics is the only system that requires being initialized
in order to query it.
@pathunstrom
Copy link
Collaborator

Yes, that's fine. If you're comfortable, I can start merging this.

@AstraLuma
Copy link
Member Author

go ahead

Copy link
Collaborator

@pathunstrom pathunstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors bors bot merged commit 09d4cc8 into ppb:canon Nov 1, 2021
@AstraLuma AstraLuma deleted the debugging branch November 1, 2021 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants