Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helpful error when translate_point_to_screen fails due to AttributeError #654

Merged
merged 2 commits into from
Feb 6, 2022

Conversation

avarice-m
Copy link
Contributor

Add detailed error info to camera.translate_point_to_screen(), which is helpful for tests

Add detailed error info to renderer.compute_rectangles(), which is helpful for when users use a VectorLike instead of a Vector

Fixes #612

@avarice-m avarice-m requested a review from a team as a code owner December 21, 2021 01:23
Copy link
Collaborator

@pathunstrom pathunstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions for improved messaging. Otherwise good.

ppb/systems/renderer.py Outdated Show resolved Hide resolved
ppb/camera.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@pathunstrom pathunstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@pathunstrom pathunstrom merged commit 118be2d into ppb:canon Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add helpful error when translate_point_to_screen fails due to AttributeError
3 participants