Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add klog for setting log levels #26

Merged
merged 1 commit into from
Dec 4, 2020
Merged

Add klog for setting log levels #26

merged 1 commit into from
Dec 4, 2020

Conversation

mkumatag
Copy link
Member

@mkumatag mkumatag commented Dec 3, 2020

Fixes: #25

@ltccci ltccci added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 3, 2020
@mkumatag
Copy link
Member Author

mkumatag commented Dec 3, 2020

/cc @bpradipt @bkhadars

@mkumatag
Copy link
Member Author

mkumatag commented Dec 3, 2020

/assign

bpradipt
bpradipt approved these changes Dec 4, 2020
View reviewed changes
Copy link
Contributor

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ltccci
Copy link
Contributor

ltccci commented Dec 4, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bpradipt, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ltccci ltccci added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2020
@ltccci ltccci merged commit fe77065 into ppc64le-cloud:master Dec 4, 2020
@mkumatag mkumatag deleted the klog branch December 4, 2020 06:59
@mkumatag mkumatag mentioned this pull request Dec 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpradipt bpradipt bpradipt approved these changes

@bkhadars bkhadars Awaiting requested review from bkhadars

Assignees

@bpradipt bpradipt

@mkumatag mkumatag

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enabled klog logging options
3 participants
@mkumatag @ltccci @bpradipt