Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set resource limits and enable FORCE_HOST_GO flag for k8s build jobs #390

Conversation

Rajalakshmi-Girish
Copy link
Collaborator

These master go post submit jobs have been internally using stable go and not the devel go after introduction of FORCE_HOST_GO flag in kubernetes/kubernetes#115377

Also setting resource limits for better node utilization.

@ppc64le-cloud-bot ppc64le-cloud-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 7, 2023
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ppc64le-cloud-bot ppc64le-cloud-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2023
@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mkumatag, Rajalakshmi-Girish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2023
@ppc64le-cloud-bot ppc64le-cloud-bot merged commit 947a262 into ppc64le-cloud:master Jul 7, 2023
3 checks passed
@ppc64le-cloud-bot
Copy link
Contributor

@Rajalakshmi-Girish: Updated the job-config configmap in namespace prow at cluster default using the following files:

  • key kubernetes-postsubmit.yaml using file config/jobs/ppc64le-cloud/builds/kubernetes-postsubmit.yaml
  • key openshift-postsubmit.yaml using file config/jobs/ppc64le-cloud/builds/openshift-postsubmit.yaml

In response to this:

These master go post submit jobs have been internally using stable go and not the devel go after introduction of FORCE_HOST_GO flag in kubernetes/kubernetes#115377

Also setting resource limits for better node utilization.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants