JsonRecorder missing charset in OutputStreamWriter, JsonLoader uses hardcoded UTF8

[skrilagg]

Hi,

just came across an issue with charset/encoding of recorded data:

deep-sampler/deepsampler-persistence-json/src/main/java/de/ppi/deepsampler/persistence/json/JsonLoader.java

Line 36 in 5dee01c

return createObjectMapper().readValue(new BufferedReader(new InputStreamReader(in, StandardCharsets.UTF_8)), JsonSampleModel.class);

reads the files with UTF8 but in

deep-sampler/deepsampler-persistence-json/src/main/java/de/ppi/deepsampler/persistence/json/JsonRecorder.java

Line 53 in 5dee01c

final BufferedWriter writer = new BufferedWriter(new OutputStreamWriter(persistentResource.writeAsStream(StandardOpenOption.TRUNCATE_EXISTING,

no charset is configured in the OutputStreamWriter.

We use Cp1252 most of the time and when loading the data from the json file, it's corrupted then.
Maybe I'm missing a configuration that I can adjust.

Regards,
Michel

[JanSchankin]

Hi Michel,

version 2.0.1 will come with the following changes:

• Default charset will be Charset.defaultCharset() for both JsonLoader and JsonRecorder.
• The new annotation @UseCharset can be used to configure the charset
• The low-level-api also has a new method to configure the charset: JsonSourceManager.builder().withCharset("cp1252").buildWithFile()

Greetings
Jan