Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UseSamplerFixture: ElementType.TYPE but ignored by JUnitPluginUtils::applyTestFixture #61

Closed
skrilagg opened this issue May 31, 2021 · 0 comments · Fixed by #79
Closed
Assignees
Labels
bug Something isn't working
Projects
Milestone

Comments

@skrilagg
Copy link

skrilagg commented May 31, 2021

Hi,

Annotation can be used at class level, javaDoc is telling the same. But JUnitPluginUtils ignores this and just tries to load from the TestMethod.

See:

        final UseSamplerFixture fixture = testMethod.getAnnotation(UseSamplerFixture.class);

        if (fixture == null) {
            return;
        }

Best regards,
Michel Pittelkow

@JanSchankin JanSchankin self-assigned this Jun 1, 2021
@JanSchankin JanSchankin added the bug Something isn't working label Jun 12, 2021
@JanSchankin JanSchankin added this to To do in Dev via automation Jul 30, 2021
JanSchankin added a commit that referenced this issue Aug 5, 2021
JanSchankin added a commit that referenced this issue Aug 5, 2021
@JanSchankin JanSchankin linked a pull request Aug 5, 2021 that will close this issue
@JanSchankin JanSchankin moved this from To do to In progress in Dev Aug 5, 2021
@JanSchankin JanSchankin added this to the v1.2.0 milestone Aug 18, 2021
Dev automation moved this from In progress to Done Sep 3, 2021
chb-ppi added a commit that referenced this issue Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Dev
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants