Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't save byte[] as base64 #72

Closed
JanSchankin opened this issue Jul 26, 2021 · 1 comment · Fixed by #73
Closed

Don't save byte[] as base64 #72

JanSchankin opened this issue Jul 26, 2021 · 1 comment · Fixed by #73
Assignees
Labels
enhancement New feature or request
Projects
Milestone

Comments

@JanSchankin
Copy link
Contributor

JanSchankin commented Jul 26, 2021

Jackson saves byte[] in base64 format. According to Stackoverflow this might have been done to save space on disk. But in our case we often want to compare the byte[] in our .json to a byte[] in the debugger. This is e.g. the case if a byte[] parameter has changed so that a Sample is not found anymore.

So we should provide a custom serializer/deserialzer for Jackson that encodes byte[] in a readable form. This serializer/desrialzer should be default.

@JanSchankin JanSchankin added the enhancement New feature or request label Jul 26, 2021
@JanSchankin JanSchankin added this to the v1.2.0 milestone Jul 26, 2021
@JanSchankin
Copy link
Contributor Author

See

public void byteArrayCanBeRecordedAndLoaded() throws IOException {
for a starting point

@JanSchankin JanSchankin added this to To do in Dev via automation Jul 30, 2021
@JanSchankin JanSchankin linked a pull request Jul 30, 2021 that will close this issue
chb-ppi added a commit that referenced this issue Aug 20, 2021
chb-ppi added a commit that referenced this issue Aug 20, 2021
Dev automation moved this from To do to Done Aug 20, 2021
JanSchankin added a commit that referenced this issue Aug 20, 2021
 byte[] should be readable in persistent files Issue #72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Dev
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants