New Map extension #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JanSchankin
commented
Jun 19, 2021
JanSchankin
commented
- Maps with primitve wrapper types as keys can now be persisted
+ BeanConverterExtensions use Types instead of Classes to be able to acces generic type parameters + PersistentBeanConverter is now sent to all BeanConverterExtensions for recursive conversions. Otherwise registered Extensions would be lost if an Extensions creates a new PersistentBeanConverter.
+ Fallback for unserializable special Collections
+Refactoring of the BeanConverterExtension as a result of the tests +Bugfixes
+Bugfixes
rcschrg
approved these changes
Jun 28, 2021
| }) | ||
| .forEach(pair -> valueMap.put(pair[0], pair[1])); | ||
|
|
||
| return (T) valueMap; |
There was a problem hiding this comment.
I think a conventional for each would be more readable, multi-line lambda + entryMap stream is too much in my opinion.
| return new Object[]{key, value}; | ||
| }) | ||
| .forEach(pair -> convertedMap.put(pair[0], pair[1])); | ||
|
|
…ary foreach instead of a Stream, since this leads to cleaner code.
|
Kudos, SonarCloud Quality Gate passed! |
I've created an issue for that (#69). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.