Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RangeError thrown when aligning some genome sequences #1

Closed
hubgit opened this issue Sep 18, 2021 · 3 comments
Closed

RangeError thrown when aligning some genome sequences #1

hubgit opened this issue Sep 18, 2021 · 3 comments

Comments

@hubgit
Copy link

hubgit commented Sep 18, 2021

I've been attempting to use this library to align some genome sequences, which would be very useful, but I'm finding that it throws a RangeError in some cases (like this example).

I can see a few places in estringDifference which return undefined, but I can't tell why that might be happening in this case.

@ppillot
Copy link
Owner

ppillot commented Sep 19, 2021

Thanks for your interest in the library. It is still early stages and rough around the edges.
I've reproduced your test case and noticed the same issue.
I've also done a second test, in a browser using a demo application, by copy/pasting the contents of the fasta files from your requests. In that second test, there is no RangeError thrown. As for the result... some segments look decently aligned and some other stretches seem dubious which might hint at unknown issues with the diagonals filtering steps.
I'll investigate the bug you have reported further. For now all the tests were made in the browser so that's another possible cause for trouble.
Thanks.

@hubgit
Copy link
Author

hubgit commented Sep 20, 2021

Strange - I first encountered the RangeError in a browser and thought it would be easier to reproduce with an example in Node! I can't think why a copy/pasted sequence would be different from data fetched from the server… (the error isn't thrown in every case, just with some sequences, for whatever reason).

Thanks for your work on this library, and don't feel any need to prioritise working on this error, I just thought it might be useful to report.

@ppillot
Copy link
Owner

ppillot commented Oct 3, 2021

I've fixed this bug. It was a special case in estring iteration terminations that was not properly accounted for.
Thanks for reporting this!

@ppillot ppillot closed this as completed Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants