Auth refactor #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is does. Gitlab doesn't support the scope you are implementing in V2.pm. That is why I have added the |
waterkip
reviewed
Oct 18, 2018
|
|
||
|
|
||
| use Data::Dumper; | ||
| print Dumper($d); |
There was a problem hiding this comment.
diag explain $d; will do the same.
waterkip
reviewed
Oct 18, 2018
| use Moose; | ||
| extends 'Docker::Registry::V2'; | ||
|
|
||
| has '+url' => (lazy => 1, default => sub { |
There was a problem hiding this comment.
You could use DockerRegistryURI for this, see Auth::Gitlab with on how to do this.
|
ok, I looked at it a bit better and I think you are save. The only difference is I had orignally a pull,push scope for getting the repository tags, so you could also edit them. But that scope can be changed when actually implementing a modify function. So I'm good. I'll make a PR to your branch. Made some changes in the gitlab provider code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@waterkip: this affects the Gitlab module, which I don't have means to try.
Implementing an Azure Container Registry module, I've found out that it's more practical to send the scope to the authenticate module (that way you can call methods for different repositories, and the scopes will automatically be calculated for you.
I've tried to adapt the Gitlab module. Can you try out this branch to see if this has impacted it's functionality?