fix(view): replace && short circuit with ternary operator in jsx

ppoffice · Oct 4, 2020 · 00300b4 · 00300b4
1 parent 2eac6df
commit 00300b4
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 16 deletions.
diff --git a/src/view/common/article_media.jsx b/src/view/common/article_media.jsx
@@ -33,21 +33,21 @@ module.exports = class extends Component {
 
     return (
       <article class="media">
-        {thumbnail && (
+        {thumbnail ? (
           <figure class="media-left">
             <a class="image" href={url}>
               <img src={thumbnail} alt={title} />
             </a>
           </figure>
-        )}
+        ) : null}
         <div class="media-content">
           <p class="date">
             <time dateTime={dateXml}>{date}</time>
           </p>
           <p class="title">
             <a href={url}>{title}</a>
           </p>
-          {categoryTags.length && <p class="categories">{categoryTags}</p>}
+          {categoryTags.length ? <p class="categories">{categoryTags}</p> : null}
         </div>
       </article>
     );

diff --git a/src/view/misc/article_licensing.jsx b/src/view/misc/article_licensing.jsx
@@ -46,38 +46,38 @@ class ArticleLicensing extends Component {
     return (
       <div class="article-licensing box">
         <div class="licensing-title">
-          {title && <p>{title}</p>}
+          {title ? <p>{title}</p> : null}
           <p>
             <a href={link}>{link}</a>
           </p>
         </div>
         <div class="licensing-meta level is-mobile">
           <div class="level-left">
-            {author && (
+            {author ? (
               <div class="level-item is-narrow">
                 <div>
                   <h6>{authorTitle}</h6>
                   <p>{author}</p>
                 </div>
               </div>
-            )}
-            {createdAt && (
+            ) : null}
+            {createdAt ? (
               <div class="level-item is-narrow">
                 <div>
                   <h6>{createdTitle}</h6>
                   <p>{createdAt}</p>
                 </div>
               </div>
-            )}
-            {updatedAt && (
+            ) : null}
+            {updatedAt ? (
               <div class="level-item is-narrow">
                 <div>
                   <h6>{updatedTitle}</h6>
                   <p>{updatedAt}</p>
                 </div>
               </div>
-            )}
-            {licenses && Object.keys(licenses).length && (
+            ) : null}
+            {licenses && Object.keys(licenses).length ? (
               <div class="level-item is-narrow">
                 <div>
                   <h6>{licensedTitle}</h6>
@@ -95,7 +95,7 @@ class ArticleLicensing extends Component {
                   </p>
                 </div>
               </div>
-            )}
+            ) : null}
           </div>
         </div>
       </div>

diff --git a/src/view/misc/web_app.jsx b/src/view/misc/web_app.jsx
@@ -39,11 +39,11 @@ class WebApp extends Component {
     return (
       <>
         <link rel="manifest" href={manifest} />
-        {themeColor && <meta name="theme-color" content={themeColor} />}
+        {themeColor ? <meta name="theme-color" content={themeColor} /> : null}
         {/* Windows Pinned Site */}
         <meta name="application-name" content={name} />
-        {tileIcon && <meta name="msapplication-TileImage" content={tileIcon} />}
-        {themeColor && <meta name="msapplication-TileColor" content={themeColor} />}
+        {tileIcon ? <meta name="msapplication-TileImage" content={tileIcon} /> : null}
+        {themeColor ? <meta name="msapplication-TileColor" content={themeColor} /> : null}
         {/* iOS home screen launcher */}
         <meta name="apple-mobile-web-app-capable" content="yes" />
         <meta name="apple-mobile-web-app-title" content={name} />

diff --git a/src/view/widget/toc.jsx b/src/view/widget/toc.jsx
@@ -101,7 +101,7 @@ class Toc extends Component {
         <li>
           <a class="level is-mobile" href={'#' + toc.id}>
             <span class="level-left">
-              {showIndex && <span class="level-item">{toc.index}</span>}
+              {showIndex ? <span class="level-item">{toc.index}</span> : null}
               <span class="level-item">{unescapeHTML(toc.text)}</span>
             </span>
           </a>