Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(generator): should not encode assets file path #5

Merged
merged 1 commit into from
Mar 17, 2020

Conversation

imaegoo
Copy link
Contributor

@imaegoo imaegoo commented Mar 17, 2020

Issue

If we create "hexo-component-inferno/assets/js/some file.js", then hexo g, Hexo generator will generate a file named "public/js/some%20file.js", then we push it to web host, the file's URL should be "https://[host]/js/some%2520file.js", that's not what we wish.

How to fix

Not to encode assets file path.

Test result

Test

@imaegoo
Copy link
Contributor Author

imaegoo commented Mar 17, 2020

@ppoffice Could you tell why assets test result does not & should not contain insight.js? Thanks.

@ppoffice ppoffice merged commit 2344514 into ppoffice:master Mar 17, 2020
@ppoffice
Copy link
Owner

@imaegoo It's like how your custom layout overrides hexo-component-inferno's view files. The insight.js is overridden by the fixture/site/themes/inferno/source/js/insight.js. By doing this a user can provide custom static files in the <theme>/source folder, which is processed by Hexo's theme processors.

@imaegoo imaegoo deleted the patch-2 branch March 17, 2020 03:43
@imaegoo
Copy link
Contributor Author

imaegoo commented Mar 18, 2020

@ppoffice Understood, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants