Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put locks to /var/lock/ppp #227

Closed
wants to merge 1 commit into from
Closed

Conversation

yarda
Copy link
Contributor

@yarda yarda commented Jan 5, 2021

Signed-off-by: Jaroslav Škarvada jskarvad@redhat.com

Signed-off-by: Jaroslav Škarvada <jskarvad@redhat.com>
@paulusmack
Copy link
Collaborator

Since this is about locking the serial port, the original intention was very much to interact with any other program that might want to use the serial port (e.g. getty, kermit, uucp, etc.), not just other pppds, so using a pppd-specific location defeats the purpose.

For me to take this I would have to be convinced that no current Linux distro has any defined convention for coordinating access to serial ports between different programs, and the only possible use of the 'lock' option is to lock against other pppds.

@Neustradamus
Copy link
Member

@yarda: Have you looked the @paulusmack comment?

1 similar comment
@Neustradamus
Copy link
Member

@yarda: Have you looked the @paulusmack comment?

@yarda
Copy link
Contributor Author

yarda commented Mar 8, 2021

@paulusmack thanks for info. It makes sense. It's not my patch, I am dropping it downstream.

@yarda yarda closed this Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants