Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Suggestion]: 发送通道中的webhook是否可以增加PATCH的请求方式 #206

Closed
BetaXOi opened this issue Aug 15, 2022 · 3 comments
Closed

[Suggestion]: 发送通道中的webhook是否可以增加PATCH的请求方式 #206

BetaXOi opened this issue Aug 15, 2022 · 3 comments
Assignees
@pppscn
Labels
help wanted Extra attention is needed

Comments

@BetaXOi
Copy link

BetaXOi commented Aug 15, 2022

是否有人曾提过类似的问题？

否（No）

你觉得APP有什么不足之处？

目前仅有POST和GET，是否可以新增PATCH请求方式，这样可以利用gihub的OpenAPI不断地将新消息推送到某个地方（如Issuse地某条评论）。
当然也可以用POST请求方式新建，但这样地结果就是导致消息越来越多，还需要当时清理。

你觉得该怎么去完善会比较好？【非必答】

No response
@BetaXOi BetaXOi added the help wanted Extra attention is needed label Aug 15, 2022
@pppscn
Copy link
Owner

pppscn commented Sep 22, 2022 •
edited
Loading

19999999999
【测试通道】恭喜您，该发送通道测试成功，请继续添加转发规则！
SIM1_测试运营商_18888888888
2022-09-22 23:04:31
pppscn的Mi 10S

pppscn added a commit that referenced this issue Sep 22, 2022
@pppscn
新增：webhook发送通道增加PUT/PATCH请求方式 #206
c00e61e
@pppscn
Copy link
Owner

pppscn commented Sep 22, 2022

请下载每周构建版本帮忙测试一下 PUT/PATCH 请求方式

https://github.com/pppscn/SmsForwarder/actions/workflows/Weekly_Build.yml

PS. 上一楼是通过smsf修改的，参考文档：https://docs.github.com/cn/rest/issues/comments#update-an-issue-comment

pppscn added a commit that referenced this issue Sep 22, 2022
@pppscn
新增：webhook发送通道增加PUT/PATCH请求方式 #206
3430dbb
@BetaXOi
Copy link
Author

BetaXOi commented Sep 23, 2022 •
edited
Loading

测试PATCH方式正常，PUT暂时没合适的环境测试

19999999999
【测试通道】恭喜您，该发送通道测试成功，请继续添加转发规则！
SIM1_测试运营商_18888888888
2022-09-23 09:42:15
Nemo的Redmi K40

@pppscn pppscn closed this as completed Sep 23, 2022
venpong pushed a commit to venpong/SmsForwarder that referenced this issue Sep 23, 2022
@github-actions
[bot] AutoMerging: merge all upstream's changes:
fee7718 
* 'main' of https://github.com/pppscn/SmsForwarder:
  整理：code review
  新增：`webhook`发送通道增加`PUT`/`PATCH`请求方式 pppscn#206
  新增：`webhook`发送通道增加`PUT`/`PATCH`请求方式 pppscn#206
  优化：仅当有WIFI网络时自动检查更新/获取提示
  新增：自动删除N天前的转发记录（0=禁用，触发机制：每次电量变化时扫描） pppscn#224
  优化：自动消除通知仅消除已匹配的通知 pppscn#204（临时方案，重复查询换取准确性）
  修复：添加发送通道按钮丢失
  修复：通话转发卡槽信息识别错误
  升级：gradle及依赖版本
  精简：去掉美团多渠道打包 升级：权限请求框架 XXPermissions
  修复：极端情况下Gson().fromJson爆空指针错误 pppscn#207
  修复：通过转发日志中重新发送短信时，{{接收时间}}错误 pppscn#218
  优化：复制服务端地址时，IPv6地址加[]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pppscn pppscn

Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pppscn @BetaXOi