Skip to content

Commit

Permalink
Drop library (and hence header files, entire -devel package, etc)
Browse files Browse the repository at this point in the history
The libtacacs library is poorly structured: it imports symbols from
tac_plus.c and utils.c rather than being entirely self-contained.  Some
of the imported symbols are likely to clash with commonly named symbols,
like 'debug'.

It's cleaner (for now) to statically link the library to the server
for now and not export it.  Unfortunately that means that the library
is present in both tac_plus and tac_pwd, but that's inherently more
secure anyway.
  • Loading branch information
pprindeville committed Dec 13, 2016
1 parent 5ddf585 commit da66077
Showing 1 changed file with 3 additions and 14 deletions.
17 changes: 3 additions & 14 deletions tacacs.spec
Original file line number Diff line number Diff line change
Expand Up @@ -46,13 +46,6 @@ Requires(postun): ldconfig
Terminal server AAA (authentication, authorization, and accounting)
server originally written by Lol Grant at Cisco.

%package devel
Summary: Development files
Provides: %{name}-static = %{version}-%{release}

%description devel
Development files (headers and libraries).

%prep -n %{name}-%{version}
%setup -n %{name}-%{version} -q

Expand All @@ -68,6 +61,7 @@ echo 'echo -n "%{version}"' > aconf/version.sh

autoreconf -f -i
%configure --enable-acls --enable-uenable --enable-warn \
--enable-static --disable-shared \
--enable-stderr-timestamps

%make_build
Expand Down Expand Up @@ -144,15 +138,10 @@ fi
%{_mandir}/man5/tac_plus.conf.5.gz
%{_mandir}/man8/tac_pwd.8.gz
%{_mandir}/man8/tac_plus.8.gz
%{_libdir}/libtacacs.so.1.0.0
%{_libdir}/libtacacs.so.1
%ghost %{_localstatedir}/log/tac_plus.log

%files devel

%{_includedir}/tacacs.h
%{_libdir}/libtacacs.so
%{_libdir}/libtacacs.a
%exclude %{_includedir}/tacacs.h
%exclude %{_libdir}/libtacacs.a
%exclude %{_libdir}/libtacacs.la

%changelog
Expand Down

0 comments on commit da66077

Please sign in to comment.