Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more tests, cleanup & code coverage #2

Merged
merged 6 commits into from
Apr 9, 2019
Merged

Added more tests, cleanup & code coverage #2

merged 6 commits into from
Apr 9, 2019

Conversation

ppshobi
Copy link
Owner

@ppshobi ppshobi commented Apr 9, 2019

No description provided.

@ppshobi ppshobi merged commit ce4d50e into master Apr 9, 2019
@codecov
Copy link

codecov bot commented Apr 9, 2019

Codecov Report

Merging #2 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #2   +/-   ##
=========================================
  Coverage     91.81%   91.81%           
  Complexity       74       74           
=========================================
  Files            21       21           
  Lines           220      220           
=========================================
  Hits            202      202           
  Misses           18       18
Impacted Files Coverage Δ Complexity Δ
src/Commands/Ingest/FlushBucketCommand.php 0% <ø> (ø) 1 <0> (ø) ⬇️
src/Ingest.php 87.5% <ø> (ø) 18 <0> (ø) ⬇️
src/SonicResponse.php 100% <100%> (ø) 11 <1> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e66bb5...95f23c3. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant