Inline external link error message constant

Not really worth it to split out the const, for one, and even if it was, then it _definitely_ should not live in `Logger` of all places.
ppy · Sep 14, 2023 · 9bc79c6 · 9bc79c6
1 parent 0778714
commit 9bc79c6
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 5 deletions.
diff --git a/osu.Framework.Android/AndroidGameHost.cs b/osu.Framework.Android/AndroidGameHost.cs
@@ -93,7 +93,7 @@ public override void OpenUrlExternally(string url)
             }
             catch (Exception ex)
             {
-                Logger.Error(ex, Logger.EXTERNAL_LINK_OPEN_ERROR_MESSAGE);
+                Logger.Error(ex, "Unable to open external link.");
             }
         }
 

diff --git a/osu.Framework.iOS/IOSGameHost.cs b/osu.Framework.iOS/IOSGameHost.cs
@@ -73,7 +73,7 @@ public override void OpenUrlExternally(string url)
             }
             catch (Exception ex)
             {
-                Logger.Error(ex, Logger.EXTERNAL_LINK_OPEN_ERROR_MESSAGE);
+                Logger.Error(ex, "Unable to open external link.");
             }
         }
 

diff --git a/osu.Framework/Logging/Logger.cs b/osu.Framework/Logging/Logger.cs
@@ -85,8 +85,6 @@ public static Storage Storage
         /// </summary>
         public string Filename => $@"{Name}.log";
 
-        public const string EXTERNAL_LINK_OPEN_ERROR_MESSAGE = "Unable to open external link.";
-
         public int TotalLogOperations => logCount.Value;
 
         private readonly GlobalStatistic<int> logCount;

diff --git a/osu.Framework/Platform/DesktopGameHost.cs b/osu.Framework/Platform/DesktopGameHost.cs
@@ -88,7 +88,7 @@ public override void OpenUrlExternally(string url)
             }
             catch (Exception ex)
             {
-                Logger.Error(ex, Logger.EXTERNAL_LINK_OPEN_ERROR_MESSAGE);
+                Logger.Error(ex, "Unable to open external link.");
             }
         }