Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bindable parsing is always culture-invariant #5176

Open
smoogipoo opened this issue May 16, 2022 · 0 comments
Open

Bindable parsing is always culture-invariant #5176

smoogipoo opened this issue May 16, 2022 · 0 comments
Labels
area:bindable priority:2 Moderately important. Relied on by some users or impeding the usability of the framework

Comments

@smoogipoo
Copy link
Contributor

smoogipoo commented May 16, 2022 •
edited

Bindable.Parse() is currently culture-invariant, but can be used to parse user input. We should probably provide an overload of that function supporting a culture parameter.

For example, see discussion ppy/osu#18271. The implementation for the text box in this case is https://github.com/ppy/osu/blob/328561f5c816088b90fb4454131be031f2d2d83a/osu.Game/Screens/Edit/Timing/IndeterminateSliderWithTextBoxInput.cs#L93-L100
@peppy peppy added the priority:2 Moderately important. Relied on by some users or impeding the usability of the framework label May 16, 2022
@Neuheit Neuheit mentioned this issue Nov 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:bindable priority:2 Moderately important. Relied on by some users or impeding the usability of the framework
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@peppy @smoogipoo