Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AddInternal needs to not be #723

Closed
peppy opened this issue May 17, 2017 · 1 comment
Closed

AddInternal needs to not be #723

peppy opened this issue May 17, 2017 · 1 comment

Comments

@peppy
Copy link
Sponsor Member

peppy commented May 17, 2017 •
edited

Today I tracked down a bug which was caused by AddInternal being used in OsuGameBase, allowing it to bypass the Content target specified by Game and add directly to a very unsafe place.

We either need to make AddInternal consider these scenarios or rethink how exposed it is.
@peppy
Copy link
Sponsor Member Author

peppy commented Nov 21, 2017

or just be very careful when using it.

@peppy peppy closed this as completed Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@peppy