Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch Trace.Assert to Debug.Assert to avoid user-facing errors #1268

Merged
merged 2 commits into from Dec 17, 2017
Merged

Switch Trace.Assert to Debug.Assert to avoid user-facing errors #1268

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0721be0
Switch Trace.Assert to Debug.Assert to avoid user-facing errors
peppy Dec 17, 2017
a5375d7
Merge branch 'master' into scrollcontainer-assert
smoogipoo Dec 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion osu.Framework/Graphics/Containers/ScrollContainer.cs
View file
Open in desktop
Expand Up @@ -287,7 +287,7 @@ protected override bool OnDrag(InputState state)
float scrollOffset = -childDelta[ScrollDim];
float clampedScrollOffset = Clamp(target + scrollOffset) - Clamp(target);

Trace.Assert(Precision.AlmostBigger(Math.Abs(scrollOffset), clampedScrollOffset * Math.Sign(scrollOffset)));
Debug.Assert(Precision.AlmostBigger(Math.Abs(scrollOffset), clampedScrollOffset * Math.Sign(scrollOffset)));

// If we are dragging past the extent of the scrollable area, half the offset
// such that the user can feel it.
Expand Down