Add readonly dictionary wrapper that removes enumerator alloc #6163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
bdach
reviewed
Feb 2, 2024
| /// <typeparam name="TKey">The type of keys in the dictionary.</typeparam> | ||
| /// <typeparam name="TValue">The type of values in the dictionary.</typeparam> | ||
| /// <returns>The read-only view.</returns> | ||
| public static SlimReadOnlyDictionaryWrapper<TKey, TValue> AsSlimReadOnly<TKey, TValue>(this Dictionary<TKey, TValue> dictionary) |
There was a problem hiding this comment.
the namespace of this is a little unfortunate but probably not worth incurring a source breaking change for
There was a problem hiding this comment.
I could split it out into a DictionaryExtensions, but it felt like too much. If you'd feel better with that then let me know and I'll do it.
Comment on lines
+20
to
+21
| IEnumerator<KeyValuePair<TKey, TValue>> IEnumerable<KeyValuePair<TKey, TValue>>.GetEnumerator() | ||
| => dict.GetEnumerator(); |
There was a problem hiding this comment.
This (and the non-generic IEnumerator one) still boxes, but I guess SlimReadOnlyListWrapper does the same so maybe fine.
There was a problem hiding this comment.
This is fine, and is the way you're supposed to implement this. The only relevant case is foreach ((SlimReadOnlyDictionary<>)dict), if you go via the interface then you're SOL no matter what.
bdach
approved these changes
Feb 2, 2024
smoogipoo
pushed a commit
to smoogipoo/osu-framework
that referenced
this pull request
Feb 3, 2024
Add readonly dictionary wrapper that removes enumerator alloc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find it pretty silly that this is still a thing even going into .NET 8. Hoping to use this for ppy/osu#26863.
In contrast to
SlimReadOnlyListWrapper<T>, the only thing gained by implementing any of the other interfaces isCopyTo(), so I've taken the liberty of not implementing every dictionary interface in existence here.