Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rearrangeable lists don't react on collection Move events #6165

Merged
merged 3 commits into from Feb 2, 2024

Conversation

Feodor0090
Copy link
Contributor

See added test.

@bdach
Copy link
Collaborator

bdach commented Feb 1, 2024

Just for general information, can you provide context where you encountered this / what this is for?

@Feodor0090
Copy link
Contributor Author

Just for general information, can you provide context where you encountered this / what this is for?

I have two screens with lists bound to single BindableList, i noticed that after i drag an item in one screen, list in the other screen doesn't update. Test shows this case.

@bdach
Copy link
Collaborator

bdach commented Feb 1, 2024

So this is in some external project / un-PR'd code? It's not related to any issue in the game?

@Feodor0090
Copy link
Contributor Author

Feodor0090 commented Feb 1, 2024

It's not related to any issue in the game?

No, it is not related.

upd: it is, see below

@Feodor0090
Copy link
Contributor Author

I had feeling that i saw cross-bound rearrangeable usages somewhere in osu!, well, i managed to find one.

2024-02-01.23-25-02.mp4

Exactly my use case: two screens, two bound lists. Notice that when i move "easy" diff down, it's still on top when i return to playlist setup screen.

@smoogipoo smoogipoo merged commit 930792c into ppy:master Feb 2, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants