Fix obsolete code in Android safe area handling by using AndroidX #6175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is more correct, as window insets are reported relative to the window/view area. Uses https://developer.android.com/reference/androidx/window/layout/WindowMetricsCalculator for compat on older platforms.
Susko3
changed the title
Susko3
commented
Feb 5, 2024
Comment on lines
-199
to
-205
| Activity.IsActive.BindValueChanged(active => | ||
| { | ||
| // When rotating device 180 degrees in the background, | ||
| // LayoutChange doesn't trigger after returning to game. | ||
| // So update safe area once active again. | ||
| if (active.NewValue) | ||
| updateSafeArea(); |
There was a problem hiding this comment.
I've tested this scenario on two of my devices, and there are no issues when using OnApplyWindowInsets().
bdach
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces obsolete calls with AndroidX compat classes that allow using new-style APIs on older android platforms.
Eg. Display.getRealSize() is deprecated on API 31+ and the suggested alternative is WindowManager.getCurrentWindowMetrics() (API 30+), so instead of having to call the old API on old platforms and the new API on new platforms, we use AndroidX WindowMetricsCalculator which does that for us.
Microsoft.Maui.Essentialsis usingXamarin.AndroidXlibraries (see nuget), so it's safe and supported to use them.