Use new BCL APIs from .NET 7/8 #6203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huoyaoyuan
commented
Mar 4, 2024
Comment on lines
-335
to
+336
| public static bool IsAsciiDigit(this char character) => character >= '0' && character <= '9'; | ||
| [Obsolete("Use char.IsAsciiDigit.")] // can be removed 20240901 | ||
| public static bool IsAsciiDigit(this char character) => char.IsAsciiDigit(character); |
There was a problem hiding this comment.
CoreLib version is slightly faster for this.
smoogipoo
reviewed
Mar 4, 2024
| return degrees * MathF.PI / 180.0f; | ||
| } | ||
| [Obsolete("Use float.DegressToRadians.")] // can be removed 20240901 | ||
| public static float DegreesToRadians(float degrees) => float.DegreesToRadians(degrees); |
There was a problem hiding this comment.
Putting these in float/double is a very interesting API decision to me.
There was a problem hiding this comment.
it's a whole shebang. personally abstractions over numbers have been loooooooooooong overdue so i'm in hook line and sinker
smoogipoo
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BCL versions are generally safer and faster.