New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect disposal pattern #6211

Merged

bdach merged 1 commit into ppy:master from smoogipoo:fix-incorrect-disposal

Mar 11, 2024

Contributor

smoogipoo commented Mar 11, 2024

This could cause problems if the object is resurrected. It's not the proper disposal pattern.


          Fix incorrect disposal pattern

9539e8e

smoogipoo added the type:code-quality label

pull-request-size bot added the size/S label

smoogipoo added type:reliability and removed type:code-quality labels

bdach self-requested a review

March 11, 2024 17:06

bdach approved these changes

View reviewed changes

Collaborator

bdach left a comment

I'm not sure how a VeldridTexture could become "resurrected" but this does look closer to how a disposal should look to me.

bdach merged commit 0c80e41 into ppy:master

21 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment