Prepare SDL2ControllerBindings class for SDL3
#6232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In SDL3, controller bindings are handled differently so the existing methods can only return true/false.
Luckily, both members have the same `[FieldOffset]` so it's not a behaviour bug.
smoogipoo
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In SDL3, controller bindings are handled differently so the existing
Get{Axis,Button}ForIndex()can't be implemented (eg. a joystick button can map to a gamepad axis, but that method expects each axis to be bound to an axis; ditto for button).Instead, the methods have been changed to
IsJoystick{Axis,Button}Bound()which can work in SDL3, and doesn't change semantics for consumers, which were only checking if the axis/button was bound or not.This PR also includes minor cleanup that just renames things.