Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Caching and sharing WeakReferences breaks everything #713

Merged
merged 1 commit into from May 15, 2017
Merged

Caching and sharing WeakReferences breaks everything #713

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 1 addition & 3 deletions osu.Framework/Configuration/Bindable.cs
View file
Open in desktop
Expand Up @@ -66,9 +66,7 @@ public Bindable(T value = default(T))

private WeakList<Bindable<T>> bindings;

private WeakReference<Bindable<T>> weakReference;
//be lazy and reuse because WeakReference is kind of "heavy"
public WeakReference<Bindable<T>> WeakReference => weakReference ?? (weakReference = new WeakReference<Bindable<T>>(this));
public WeakReference<Bindable<T>> WeakReference => new WeakReference<Bindable<T>>(this);

/// <summary>
/// Binds outselves to another bindable such that they receive bi-directional updates.
Expand Down