Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User contributions to ranking/nominating other maps not displayed on modding profile #10384

Open
Ephemeralis opened this issue Jul 18, 2023 · 7 comments

Comments

@Ephemeralis
Copy link
Member

Ephemeralis commented Jul 18, 2023

We're currently trying to track the number of maps a modder user has helped achieve Ranked status over the years. It was brought up during internal discussions that these values should also be publicly visible on a users /modding profile page.

This is trivial for "moddingv2" sets using the new system since they're tracked in the nominated_beatmapset_count apiv2 call, but maps ranked before this system are not currently tracked at all, much to the dismay of older contributors.

For example, ranked map counts visible on the old /p/modranking view do not contribute to this number, and they probably should.

This comes with two points to consider:

  • We can probably get a count of maps ranked from counting osu_beatmapsets.approvedby_id before the cutoff date of whenever we switched over to the new "moddingv2" system. Some investigation will need to be done to figure out what this date actually is.
  • Nominations from this era are more difficult, as they were denoted via phpbb bubble (and bubble pop) icons attached to individual posts. I have no insight as to how this might be retrieved, if it is possible (or feasible) at all.
@Andrea1992wr
Copy link

Andrea1992wr commented Jul 18, 2023

After some research, according to this page here the cutoff date where BAT became QAT is 21st August 2014.

Even though, moddingv2 was fully implemented during 2017, can't remember the exact date sadly.

@cl8n
Copy link
Member

cl8n commented Jul 25, 2023

finding old nominations can be done by finding replies with bubble, heart, or flame icon on topics that are linked to ranked or approved mapsets. I think gamemode icons were used too for hybrid sets

but from what I can tell it may be problematic to figure out which of those are the final nominations that resulted in the map being ranked, because there's no record left of when bubbles were popped, unless it was via a post with the pop icon. even then, I think some of those posts were just edited to become a bubble again after the BN figured out the issue with the mapper

my only idea then is to select the last X icons from each thread where X is how many nominators should have been required for the map at that period in time. I don't know enough about modding history to know if X is easy to figure out. but this also may have problems for exceptional maps with weird icon history, if that's ever been a thing (e.g. I had this topic in mind, turns out it actually did get normal bubbles in the end though)

@Digitalfear117
Copy link

Digitalfear117 commented Apr 5, 2024

I'm not entirely sure if this is the best way of determining the point at which things were switched to modding v2, but doing a modding search on banchobot, and limiting it to the following selection (Ranked, All modes, Note + Review) gives us this list. This appears to be an descending order list of forum ID's for all ranked mapsets that were ranked under modding v1. This is because banchobot sent a message on all ranked modding v1 maps informing users that any following discussion has to happen on the v2 modding discussion page.

Screenshot showing the banchobot search

The newest map among this group of maps was submitted on November 28th at 19:34:46 0 UTC, which is this one, which is beatmapset 699733. Incrementing the beatmapset ID until you get the next ranked map gets you to this map forum page. which was fully modded and ranked using modding v2, that is beatmapset 699745. This map was submitted on November 28th at 20:59:12 0 UTC. About an hour and a half after what I believe is the last map submitted under modding v1.

As for the 2nd matter of determining who actually finalized the bubbling of each set... I think going based on the last bubble/heart in all modding v1 forum threads isn't a terrible idea. That's assuming there is no master list of bubbles and pops that you have 👀. Here is a list of roughly 75 maps and who ranked it based on forum post bubbles that I compiled into a spreadsheet I created manually by searching forum threads.

Screenshot of my spreadsheet where you can see I manually looked for the last bubbles to determine who nominated the map in the end

If it has to be a manual process like I did for the sheet above, I wouldn't mind spending time and digging through forum threads and figuring out who bubbled maps this way. The only issue is that on the new site these aren't visible at all anymore. For the spreadsheet I've relied mostly on the wayback machine for any map that had archived versions of the threads on old site. If beatmapset forums on old.ppy.sh could be enabled for the bubble hunters it would make things a lot easier lol.

Screenshots comparing old and new site, where on old site you can see a bubble, but on new site you cannot

@notbakaneko
Copy link
Collaborator

We can back fill nominations on old maps, but we do need some way to reliably determining who did the nomination.

@Digitalfear117
Copy link

Digitalfear117 commented Apr 5, 2024

Did this feature survive? This is on the original osu! Changelog back in 2008.

“(+) Web: BAT who ranked map is visible on beatmap listing. Slight design changes to make listing more compact/readable.”

Sure enough, using the wayback machine on the beatmapset listing does show who ranked what maps! The issue is this only seems to show the last person who bubbled it on the site. This feature is visible on the wayback machine until September 22nd 2012. Afterwards the design changed to what we have now on old.ppy.sh. I have no idea if this was still stored after, or if the other bubbler was stored at all in any way besides forum messages…

https://web.archive.org/web/20090120002022/http://osu.ppy.sh/p/beatmaplist

@Digitalfear117
Copy link

Digitalfear117 commented Apr 7, 2024

Manually checking the data from the score dumps I see that the last bubbler for nearly every ranked map in the game is already there. Taking a look at osu_beatmapsets.sql there is a column called "approvedby_id" which shows the last bubbler on all but 137 beatmapsets. I manually searched through the wayback machine to see if these ID's matched up with the data shown on the site back in the day and it's 1 for 1. In the end my search wasn't particularly useful. This was my sheet where I searched and compared https://docs.google.com/spreadsheets/d/18rVsl7h2VlW2Pr8pfcrA6ObNfqu6H9KsW5g3hd0yk1s/edit?usp=sharing

However since we have this data already of who was the last bubbler for all ranked modding v1 maps, I think that we should give these users credit for nominating the map. The question really is not "who is the last bubbler", it's really, "who was the 2nd to last bubbler". All I can suggest is choosing the other bubbler based on the last message with the bubble icon in the beatmap thread, since I don't have access to other data points.

For the 137 maps that have NULL in this column there are really three different ways I see them going. On a map like DISCO PRINCE, peppy was realistically the only user who could have ranked the map in these situations. The idea of a map showing just the single nominator of peppy sounds like quite the amusing power play, but if there must be a second I'd just put banchobot 🤷‍♂️. Other maps such as s/162 seem to show that it was ranked by a Beatmap Modder, Extor, so maybe in this case someone could go through and manually select the users who bubbled them, or just have it go based on the bubbles on the thread. If you don't like those ideas, the ones with NULL in the column could show no nominators like they do now, but I think that would be a bit sad. I like the idea of crediting the nominators for all the maps we can 😄. Preserving every bit of osu! history is my goal.

@cl8n
Copy link
Member

cl8n commented Apr 8, 2024

the only concrete data is who did the final ranking, yeah. the best you can do to figure out everything else is to analyze forum icons. I think the best way to go about this would be for @peppy to provide data about which forum posts attached to beatmaps have relevant icons (bubble, heart, flame, bubble pop, any gamemode icon), and then for someone else (@Digitalfear117 + I know a few others that would be very interested) to figure out how those translate into the "final nominators" of each map. I also looked into this a lot earlier and found no straightforward way to determine correct nominators automatically, I think it depends a lot on how the ranking system worked at each time period, and also there are outliers regardless

For the 137 maps that have NULL in this column [...]

it's so little that we could just go through every one (with the help of relevant icon data) and figure it out. I think in the end, this entire issue will rely on someone manually filling in data or creating many very specific rules to fill in data based on icon history anyway.

also, didn't see this mentioned yet, but there is another crowdsourced project doing the same thing here https://omdb.nyahh.net/project-legacy/ . I would not trust this data 100% by itself, but I'm sure it would be great to cross-reference along the way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants