Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from CoffeeScript to TypeScript #4936

Open
smorimoto opened this issue Sep 12, 2019 · 12 comments
Open

Migrate from CoffeeScript to TypeScript #4936

smorimoto opened this issue Sep 12, 2019 · 12 comments
Labels
priority:3 Nice to have, at some point type:code-quality

Comments

@smorimoto
Copy link

smorimoto commented Sep 12, 2019

CoffeeScript is already a little obsoleted. Does the core development team interested in migrating to TypeScript or JavaScript and/or improving React performance? (*This is a question. Not an issue.)

@cl8n
Copy link
Member

cl8n commented Sep 12, 2019

new components are already being written in typescript and I assume that means all of the coffeescript will eventually be replaced too

@smorimoto
Copy link
Author

Yes, I knew that, so I wondered. Also some TypeScript codes are obsolete and should be checked by ESLint. I can set it up, So I can create PR. For example, it's better to use "type" instead of "interface". (Except for some complicated packages.)

@smorimoto
Copy link
Author

*As far as I remember, TSLint will be deprecated later this year.

@LiquidPL
Copy link
Contributor

There's a lot of code written in CoffeeScript and I'm pretty sure that migrating all of it over would be a major effort.

Also yeah, new components are being done in TypeScript already, so there's a good chance a lot of components will be rewritten anyway as we rework them.

@smorimoto
Copy link
Author

It over would be a major effort.

I really think so. I just switched to ESLint and there are about 600 errors.

@smorimoto
Copy link
Author

I think it's enough if you do the migrate when you need it.

@peppy
Copy link
Sponsor Member

peppy commented Sep 12, 2019

You're more than welcome to help with this, but it is (as you can understand) a very low priority.

@peppy peppy added this to the Backlog milestone Sep 12, 2019
@smorimoto
Copy link
Author

I get it! I will try it when I have much time!

@notbakaneko
Copy link
Collaborator

Moving to typescript is the eventual goal and we'd be glad to accept contributions in migrating the existing coffeescript to typescript. We'd also accept contributions for better test coverage and typings for existing coffeescript modules to help in migrating to typescript.

@LiquidPL
Copy link
Contributor

I don't think there's a reason to close this one though.

@smorimoto smorimoto reopened this Sep 20, 2019
@smorimoto
Copy link
Author

I opened this as a question and so I close this. but I reopened because this included in milestone.

@peppy peppy removed this from the Backlog milestone Mar 2, 2020
@taylankasap
Copy link
Contributor

This should be mentioned in CONTRIBUTING.md since it also mentions a similar thing (moving from Laravel Blades to React).

@peppy peppy added priority:3 Nice to have, at some point and removed priority:4 labels Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:3 Nice to have, at some point type:code-quality
Projects
None yet
Development

No branches or pull requests

6 participants