Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow profile badge recipients to sort appearance order #8844

Open
Ephemeralis opened this issue Apr 24, 2022 · 6 comments
Open

Allow profile badge recipients to sort appearance order #8844

Ephemeralis opened this issue Apr 24, 2022 · 6 comments

Comments

@Ephemeralis
Copy link
Member

Currently, profile badges are sorted purely based on when they're awarded. For most users with only a handful of badges, this is often enough.

The scene has been mature enough that we're starting to get a substantial number of users with high badge count. It would probably be best to give them the option to sort their badges as they like, since it can get visually very noisy on certain high-achieving players.

@peppy
Copy link
Sponsor Member

peppy commented Apr 25, 2022

I'm not sure I understand the requirements. Is this about users wanting to show off certain badges but not others? Or is this about them taking up too much space?

Previously these badges would take up a confined about of space (and carousel rotate IIRC?) – if this issue is about space then maybe we should look at bringing that back.

If it's about further customisation then I'm not sure. It's a considerable amount of effort to make customisation possible. And even if we did, I think it would be the option to hide or show, not re-order.

@RockRoller01
Copy link
Contributor

(and carousel rotate IIRC?)
unless you are talking about the old website, no, afaik they have just always broken into more lines.

As far as i understood, the issue is about allowing people to order the badges, as they are currently just ordered by date which is visually messy. The users could minimise if they were able to order their badges, in the case of the provided screenshot e.g. put all twc badges after each other, put all spotlight badges together etc:
before:
image
image

after:
image
image

@Ephemeralis please verify if i understood it correctly.
Personally seems like a lot of work to me, dont know if its worth it and probably would be good enough already if all spotlight badges and all championship badges were sorted?

@Ephemeralis
Copy link
Member Author

RockRoller is correct.

Support for automatic sorting by tournament series would probably do the trick in most circumstances, if that is any easier to implement. Perhaps a tag field added to osu_badges and sorting which prioritizes tags alphabetically (sorting by awarded for each tag), and then all untagged badges by awarded date afterwards.

@peppy
Copy link
Sponsor Member

peppy commented Apr 26, 2022

Separating spotlight badges into a separate line/grouping seems like the way forward if that's the intention. But I thought these were supposed to be temporary?

@respektive
Copy link

respektive commented Apr 26, 2022

But I thought these were supposed to be temporary?

Only the Rhythm Incarnate badges are permanent, eg. the best of a season.

@cl8n
Copy link
Member

cl8n commented May 29, 2024

I don't really see the problem here. I have no desire to see certain badges grouped together when they are all clearly ordered in a sensible way already (chronologically)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants