Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out a replacement for #1 links in tables #8109

Open
Walavouchey opened this issue Oct 3, 2022 · 6 comments
Open

Figure out a replacement for #1 links in tables #8109

Walavouchey opened this issue Oct 3, 2022 · 6 comments

Comments

@Walavouchey
Copy link
Member

i think this convention started in tournament articles as a way to prevent spamming "link" or some other wording in tables, for situations where any other name for the link isn't applicable since it's covered by the table header.

i can think of two solutions:

  • an image
  • a website-implemented widget

i'm imagining some kind of button- or card-looking thing, but if you have any good ideas they would be appreciated

@TicClick
Copy link
Contributor

TicClick commented Oct 4, 2022

I read this as a non-issue, simply because there are no alternative solutions: if it's not going to be #1 all the time (is there even #2?), it will be something else just as repetitive. an image (I assume you are looking for a pretty ([ Match link ]) button or something) would require one to copy and paste the reference fron one article to another just the same way we did it for flags.

a website widget, however it may look, is a bit more useful, but I don't see much benefit in making it solely for the wiki purposes (not sure how often people share multiplayer links on forums -- supporting that widens the scope of work for whoever's in charge).

I guess this is a direct consequence of the layout chosen for the tournament results. since real link title (Match link) is moved to the column title row, the links themselves have no real title, while it should have been at least the name of the match:

- [Germany 5 : 2 Australia](https://osu.ppy.sh/community/matches/100000001)
- [Malaysia 2 : 5 France](https://osu.ppy.sh/community/matches/100000002)
- [Austria 2 : 5 Norway](https://osu.ppy.sh/community/matches/100000003)

@TicClick TicClick changed the title Figure out a replacement for "#1" links in tables Figure out a replacement for \#1 links in tables Oct 4, 2022
@TicClick TicClick changed the title Figure out a replacement for \#1 links in tables Figure out a replacement for #1 links in tables Oct 4, 2022
@TicClick TicClick changed the title Figure out a replacement for #1 links in tables Figure out a replacement for #1 links in tables Oct 4, 2022
@Walavouchey
Copy link
Member Author

is there even #2?

71 out of 17876 in tournament articles. even if there are two of them... we could just have two widgets/images

it will be something else just as repetitive. an image (I assume you are looking for a pretty ([ Match link ]) button or something) would require one to copy and paste the reference fron one article to another just the same way we did it for flags

yes, it would still be repetitive since it's a match link, but it would require orders of magnitude less work than hundreds of flag references. the point of this is to have something more pleasing/sensible than a "#1".

a website widget, however it may look, is a bit more useful, but I don't see much benefit in making it solely for the wiki purposes (not sure how often people share multiplayer links on forums -- supporting that widens the scope of work for whoever's in charge).

it would just be for the wiki, yes. as you said, other places than the wiki would not have any immediate need/use for this.

I guess this is a direct consequence of the layout chosen for the tournament results. since real link title (Match link) is moved to the column title row, the links themselves have no real title, while it should have been at least the name of the match:

going at this from an aesthetic point of view, tables are a must for the alignment of flags and country names. very long lists just look a lot worse. this is why i required the osu! originals article to have tables

and (let me rant a bit) i hope my sentiment is understandable when i say that not using the features available would make for a wiki that is very unappealing to look at. i know we're limited by markdown but infoboxes and footnotes really were a step forward, and i'd encourage not just things that will make the osu! wiki look more like wikipedia.

the wiki really needs more work on the graphical side (not just the myriad of outdated images). this is a long-term goal of mine - for example, i'd love for the judgement articles to have infographics that explain hit windows (imagine a ur bar), and the notelock article to have pictures that show how hit windows interact. things like this would really polish the usefulness of the wiki for beginner rhythm game players and players more familiar with other games.

so no, this is not a non-issue. this is an area that can be improved (albeit by a small amount).

@TicClick
Copy link
Contributor

I totally share your sentiment!

Walavouchey added a commit to pishifat/osu-wiki that referenced this issue Apr 15, 2023
for more info see ppy#8109
@Walavouchey
Copy link
Member Author

thoughts

image

basically the same idea as in https://osu.ppy.sh/wiki/en/osu!_originals. not sure if there's a better way to represent mp links (but they'd have tooltips)

@cl8n
Copy link
Member

cl8n commented Mar 5, 2024

I'm fine with this suggestion too, but I can't understand why you'd prefer it over my PR you closed, that one has meaningful buttons instead of vague icon that you probably need to view the tooltip for

@Walavouchey
Copy link
Member Author

Walavouchey commented Mar 5, 2024

they weren't buttons, just text links. the icon may be vague because there's no better signifier for "mp link" atm, but it's still better than spamming the same word for each line of each table. you already have enough bits of information to convey via text and what each of the same links point to is not one of them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants