Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CFIC: Semifinals #2123

Merged
merged 5 commits into from
Mar 14, 2019
Merged

CFIC: Semifinals #2123

merged 5 commits into from
Mar 14, 2019

Conversation

fajar13k
Copy link
Contributor

  • Update to Semifinals state
  • Fix some links to fit ASC
  • Fix translation

cl8n
cl8n requested changes Mar 14, 2019
View reviewed changes
Copy link
Member

@cl8n cl8n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since you are cleaning up the links anyway could you add osu.ppy.sh to the front of beatmap links too (they are missing in group stage mappools)

wiki/Tournaments/CFC/CFIC_1/en.md
| #15 | -\[Smoked\]- | ![][flag_BE] | ![][flag_FR] | floflim | **17:00** |
| #17 | redjiii | ![][flag_FR] | ![][flag_FR] | floflim | **17:30** |
| #22 | Sageru | ![][flag_FR] | ![][flag_FR] | Zard | **18:00** |
¹ Encounter dependent on loser of Match #2 (SF) and winner of Match #5 (QF)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two spaces at the end and remove the newline on 96
it's basically a list but indexed by superscript, so...

wiki/Tournaments/CFC/CFIC_1/fr.md
| #15 | -\[Smoked\]- | ![][flag_BE] | ![][flag_FR] | floflim | **17:00** |
| #17 | redjiii | ![][flag_FR] | ![][flag_FR] | floflim | **17:30** |
| #22 | Sageru | ![][flag_FR] | ![][flag_FR] | Zard | **18:00** |
¹ Confrontation dépendant du perdant du Match #2 (SF) et du gagnant du Match #5 (QF)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as english

WalterToro
WalterToro previously approved these changes Mar 14, 2019
View reviewed changes
@WalterToro WalterToro merged commit 08059a1 into ppy:master Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cl8n cl8n cl8n requested changes

@WalterToro WalterToro WalterToro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fajar13k @cl8n @WalterToro