Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MacOS installation guide #2171

Merged
merged 12 commits into from
Apr 15, 2019
Merged

Add MacOS installation guide #2171

merged 12 commits into from
Apr 15, 2019

Conversation

TheNinty
Copy link
Contributor

Adds an installation guide for MacOS, and splits up the Windows and MacOS guides.

Copy link
Member

@cl8n cl8n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add

---
outdated: true
---

to the beginning of each other language's file for Installation (if it's not there already), seems like a relevant enough section to translate

wiki/Installation/en.md Outdated Show resolved Hide resolved
wiki/Installation/en.md Outdated Show resolved Hide resolved
wiki/Installation/en.md Outdated Show resolved Hide resolved
MegaApplePi and others added 3 commits April 13, 2019 01:01
Co-Authored-By: TheNinty <45942331+TheNinty@users.noreply.github.com>
Co-Authored-By: TheNinty <45942331+TheNinty@users.noreply.github.com>
Co-Authored-By: TheNinty <45942331+TheNinty@users.noreply.github.com>
MegaApplePi
MegaApplePi previously approved these changes Apr 13, 2019
@TheNinty
Copy link
Contributor Author

Should there be separate articles for each installation method?

@TPGPL
Copy link
Contributor

TPGPL commented Apr 13, 2019

@TheNinty you could also delete L3 and replace This page will roughly tell you how to get osu! working on your Windows device. with This page will roughly tell you how to get osu! working on your various devices.

@TheNinty
Copy link
Contributor Author

Some of the methods for doing other things are different, like adding a skin.

wiki/Installation/en.md Outdated Show resolved Hide resolved
wiki/Installation/en.md Outdated Show resolved Hide resolved
wiki/Installation/en.md Outdated Show resolved Hide resolved
@TheNinty
Copy link
Contributor Author

ok I made a new article at wiki/Installation/macOS/en.md and reverted the old one to it's original state

wiki/Installation/en.md Outdated Show resolved Hide resolved
@TheNinty
Copy link
Contributor Author

TheNinty commented Apr 15, 2019

the installation en.md file now has a link to the macOS version of the installer

edit: I went through the requested changes, everything should be good now.

@TPGPL TPGPL merged commit 46a4b12 into ppy:master Apr 15, 2019
@MegaApplePi MegaApplePi mentioned this pull request Sep 7, 2019
52 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants