Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ranking Criteria updates #2300

Merged
merged 3 commits into from Jun 24, 2019
Merged

Ranking Criteria updates #2300

merged 3 commits into from Jun 24, 2019

Conversation

pishifat
Copy link
Contributor

@pishifat pishifat commented Jun 8, 2019

mostly small changes

clarified some glossary words in osu rc: https://osu.ppy.sh/community/forums/topics/898895
added recommendation for unknown chinese metadata: https://osu.ppy.sh/community/forums/topics/904342
clarification for 1/4 and 1/2 rhythm spacing guideline: https://osu.ppy.sh/community/forums/topics/891732 (generalized this one based on review)
adjusting for mistake in letterboxing rule/guideline: https://osu.ppy.sh/community/forums/topics/918503
a few metadata clarifications: https://osu.ppy.sh/community/forums/topics/885418
and some formatting fixes for song setup settings
...and a couple mistakes fixed on the mania rc


wiki/Ranking_Criteria/osu!mania/en.md Outdated Show resolved Hide resolved
wiki/Ranking_Criteria/osu!/en.md Outdated Show resolved Hide resolved
wiki/Ranking_Criteria/osu!/en.md Outdated Show resolved Hide resolved
@Xinnoh
Copy link
Contributor

Xinnoh commented Jun 9, 2019

I don't know how to suggest changes to parts of the file that you haven't changed
Mania RC fixes
use less keys, -> use fewer keys
amount of keys -> number of keys (amount and less is used for non countable things)
favor -> favour
9 consecutives -> 9 consecutive
in a trills -> in trills

@RushFTK
Copy link
Contributor

RushFTK commented Jun 10, 2019

how about add changes in #2293 if no problem?

Copy link
Contributor

@RushFTK RushFTK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- **No column can be left empty.** If you want to use fewer keys, change the amount of keys in the Song Setup.

@RushFTK
Copy link
Contributor

RushFTK commented Jun 10, 2019

- **No column can be left empty.** If you want to use fewer keys, change the amount of keys in the Song Setup.

i made mistake, really dont know how to use that, even delete it ,sry to make troubles.- -

@TPGPL TPGPL added the update label Jun 21, 2019
@Okorin Okorin merged commit 71461e4 into ppy:master Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants