Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AiMod wiki page #3807

Merged
merged 10 commits into from Jul 7, 2020
Merged

Update AiMod wiki page #3807

merged 10 commits into from Jul 7, 2020

Conversation

hypercyte
Copy link
Contributor

@hypercyte hypercyte commented Jul 2, 2020 •
edited

Completes a task from #3128

  • Updated the aimod warning/error messages
  • Included flaws + suggested alternative
  • Better looking screenshot of the window with up-to-date warnings

I left various comments around for things I'm not sure about.

Could get some thoughts on the flaws too!

@hypercyte
Update / cleanup AiMod wiki page
2a53f4e 
- updated the aimod messages
- flaws + alternative
- better looking screenshot of the window with up-to-date warnings
@cl8n cl8n added this to the July 2020 milestone Jul 2, 2020
@Pennek
Copy link
Contributor

Pennek commented Jul 3, 2020

remind me to take a look at this if i havent reviewed in a week or so

cl8n
cl8n requested changes Jul 6, 2020
View reviewed changes
Copy link
Member

@cl8n cl8n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image should be cropped a little better and have the window in focus

otherwise looks good & I rewrote the intro of this a bit too. I'll take a look into your comments about the warnings/errors later

@cl8n cl8n merged commit ac63601 into ppy:master Jul 7, 2020
@hypercyte hypercyte deleted the update-aimod branch July 9, 2020 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cl8n cl8n cl8n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
July 2020
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hypercyte @Pennek @cl8n