Skip to content

Commit

Permalink
Assign empty hit windows to HoldNoteBody
Browse files Browse the repository at this point in the history
It's not a timed object, so following precedent, it should have empty
hitwindows.

This is not actually just aesthetics; several components check whether a
hitobject has empty hitwindows to determine whether to include it on
various HUD displays and results screen components where timed objects
are explicitly involved.
  • Loading branch information
bdach committed Oct 11, 2023
1 parent a1a46e5 commit 3f29f27
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions osu.Game.Rulesets.Mania/Objects/HoldNoteBody.cs
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

using osu.Game.Rulesets.Judgements;
using osu.Game.Rulesets.Mania.Judgements;
using osu.Game.Rulesets.Scoring;

namespace osu.Game.Rulesets.Mania.Objects
{
Expand All @@ -15,5 +16,6 @@ namespace osu.Game.Rulesets.Mania.Objects
public class HoldNoteBody : ManiaHitObject
{
public override Judgement CreateJudgement() => new HoldNoteBodyJudgement();
protected override HitWindows CreateHitWindows() => HitWindows.Empty;
}
}

0 comments on commit 3f29f27

Please sign in to comment.