Add inline commentary in Mod{Day,Night}core about different speed a…

…djustments
ppy · Oct 18, 2023 · cff69d6 · cff69d6
1 parent 9907adc
commit cff69d6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/osu.Game/Rulesets/Mods/ModDaycore.cs b/osu.Game/Rulesets/Mods/ModDaycore.cs
@@ -33,6 +33,8 @@ protected ModDaycore()
         {
             rateAdjustHelper = new RateAdjustModHelper(SpeedChange);
 
+            // intentionally not deferring the speed change handling to `RateAdjustModHelper`
+            // as the expected result of operation is not the same (daycore should preserve constant pitch).
             SpeedChange.BindValueChanged(val =>
             {
                 freqAdjust.Value = SpeedChange.Default;

diff --git a/osu.Game/Rulesets/Mods/ModNightcore.cs b/osu.Game/Rulesets/Mods/ModNightcore.cs
@@ -45,6 +45,8 @@ protected ModNightcore()
         {
             rateAdjustHelper = new RateAdjustModHelper(SpeedChange);
 
+            // intentionally not deferring the speed change handling to `RateAdjustModHelper`
+            // as the expected result of operation is not the same (nightcore should preserve constant pitch).
             SpeedChange.BindValueChanged(val =>
             {
                 freqAdjust.Value = SpeedChange.Default;