Skip to content

Commit

Permalink
Merge pull request #27176 from peppy/document-classic-mod-no-rank
Browse files Browse the repository at this point in the history
Add inline documentation as to why classic mod is not ranked
  • Loading branch information
bdach committed Feb 15, 2024
2 parents 409dfd3 + 9e9297b commit e10c4c7
Showing 1 changed file with 11 additions and 0 deletions.
11 changes: 11 additions & 0 deletions osu.Game/Rulesets/Mods/ModClassic.cs
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,16 @@ public abstract class ModClassic : Mod
public override LocalisableString Description => "Feeling nostalgic?";

public override ModType Type => ModType.Conversion;

/// <summary>
/// Classic mods are not to be ranked yet due to compatibility and multiplier concerns.
/// Right now classic mods are considered, for leaderboard purposes, to be equal as scores set on osu-stable.
/// But this is not the case.
///
/// Some examples for things to resolve before even considering this:
/// - Hit windows differ (https://github.com/ppy/osu/issues/11311).
/// - Sliders always gives combo for slider end, even on miss (https://github.com/ppy/osu/issues/11769).
/// </summary>
public sealed override bool Ranked => false;
}
}

0 comments on commit e10c4c7

Please sign in to comment.