Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings will not open if there is an incorrect ruleset. #10053

Closed
Moltanicaa opened this issue Sep 3, 2020 · 3 comments · Fixed by #10061
Closed

Settings will not open if there is an incorrect ruleset. #10053

Moltanicaa opened this issue Sep 3, 2020 · 3 comments · Fixed by #10061

Comments

@Moltanicaa
Copy link

Describe the bug:
If the folder with the rulesets contains a mode file that cannot be opened in this version, then for some reason the settings menu stops working (It just doesn't open in any way). If you remove the ruleset, then everything becomes normal. The only problem is that this is a completely non-obvious problem.
Screenshots or videos showing encountered issue:
image
Example .dll - https://github.com/karaoke-dev/karaoke/releases/tag/2020.0802.0
https://youtu.be/rGmc74K0hrY (When you click on the settings icon, the screen shifts to the right, but nothing else happens.)
osu!lazer version:
2020.093.0

@peppy peppy added this to the September 2020 milestone Sep 3, 2020
@peppy
Copy link
Sponsor Member

peppy commented Sep 3, 2020

For the third time, please follow instructions. We need you to include everything mentioned in the issue template, including logs. This is your last chance.

@LumpBloom7
Copy link
Contributor

LumpBloom7 commented Sep 3, 2020

This is specifically due to osu-karaoke trying to create a FullscreenOverlay for the osu-karaoke changelogs, which got changed in #10044.

The button to toggle the karaoke changelog is within the settings subsection for the ruleset, causing the settings overlay to fail.

Here is the log for that specific problem:
runtime.log

Strange thing to note:
On a fresh copy of the latest lazer (no db), osu-karaoke will fail to load entirely, causing no issues with the settings overlay. However if lazer updated to the latest version with that ruleset previously added, it'll complain about not being able to add the ruleset, but the ruleset will still be loaded, and causing problems with things down the line.

Related PR on osu-karaoke: karaoke-dev/karaoke#158

@peppy
Copy link
Sponsor Member

peppy commented Sep 3, 2020

Thanks a lot.

Probably a good reminder that we should be making such classes internal to avoid this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants