Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird error on skin editor when quickly swap between Song Select and Gameplay screen #17696

Closed
smoogipoo opened this issue Apr 7, 2022 Discussed in #17691 · 0 comments · Fixed by #17704
Closed

Weird error on skin editor when quickly swap between Song Select and Gameplay screen #17696

smoogipoo opened this issue Apr 7, 2022 Discussed in #17691 · 0 comments · Fixed by #17704
Assignees

Comments

@smoogipoo
Copy link
Contributor

Discussed in #17691

Originally posted by HelloYeew April 7, 2022
I'm not sure on how to fully reproduce on this but mainly just quickly swap between Song Select and Gameplay screen and add some sprite to the screen.

2022-04-07.01-32-09.mp4

This is the log when it's not error :

2022-04-06 18:32:20 [verbose]: 📺 OsuScreenStack#428(depth:5) suspended PlaySongSelect#630 (waiting on PlayerLoader#648)
2022-04-06 18:32:20 [verbose]: 📺 OsuScreenStack#428(depth:6) loading PlayerLoader#648
2022-04-06 18:32:20 [verbose]: 📺 OsuScreenStack#428(depth:6) entered PlayerLoader#648
2022-04-06 18:32:20 [verbose]: 📺 OsuScreenStack#428(depth:5) exit from PlayerLoader#648
2022-04-06 18:32:20 [verbose]: 📺 OsuScreenStack#428(depth:5) resume to PlaySongSelect#630

The log told this error :

2022-04-06 18:32:23 [verbose]: 📺 OsuScreenStack#428(depth:5) suspended PlaySongSelect#630 (waiting on PlayerLoader#136)
2022-04-06 18:32:23 [verbose]: 📺 OsuScreenStack#428(depth:6) loading PlayerLoader#136
2022-04-06 18:32:23 [verbose]: 📺 OsuScreenStack#428(depth:6) entered PlayerLoader#136
2022-04-06 18:32:24 [verbose]: 📺 OsuScreenStack#428(depth:5) exit from PlayerLoader#136
2022-04-06 18:32:24 [verbose]: 📺 OsuScreenStack#428(depth:5) resume to PlaySongSelect#630
2022-04-06 18:32:24 [error]: An unhandled error has occurred.
2022-04-06 18:32:24 [error]: System.ObjectDisposedException: Children cannot be mutated on a disposed drawable.
2022-04-06 18:32:24 [error]: Object name: 'Container<SelectionBlueprint<ISkinnableDrawable>>'.
2022-04-06 18:32:24 [error]: at osu.Framework.Graphics.Containers.CompositeDrawable.AddInternal(Drawable drawable)
2022-04-06 18:32:24 [error]: at osu.Framework.Graphics.Containers.Container`1.AddInternal(Drawable drawable)
2022-04-06 18:32:24 [error]: at osu.Game.Screens.Edit.Compose.Components.BlueprintContainer`1.AddBlueprintFor(T item)
2022-04-06 18:32:24 [error]: at osu.Game.Skinning.Editor.SkinBlueprintContainer.AddBlueprintFor(ISkinnableDrawable item)
2022-04-06 18:32:24 [error]: at osu.Game.Skinning.Editor.SkinBlueprintContainer.componentsChanged(Object sender, NotifyCollectionChangedEventArgs e)
2022-04-06 18:32:24 [error]: at osu.Framework.Bindables.BindableList`1.add(T item, BindableList`1 caller)
2022-04-06 18:32:24 [error]: at osu.Framework.Bindables.BindableList`1.add(T item, BindableList`1 caller)
2022-04-06 18:32:24 [error]: at osu.Game.Skinning.SkinnableTargetContainer.Add(ISkinnableDrawable component)
2022-04-06 18:32:24 [error]: at osu.Game.Skinning.Editor.SkinEditor.placeComponent(ISkinnableDrawable component, Boolean applyDefaults)
2022-04-06 18:32:24 [error]: at osu.Game.Skinning.Editor.SkinEditor.placeComponent(Type type)
2022-04-06 18:32:24 [error]: at osu.Game.Skinning.Editor.SkinComponentToolbox.<attemptAddComponent>b__6_0(Type t)
2022-04-06 18:32:24 [error]: at osu.Game.Skinning.Editor.SkinComponentToolbox.ToolboxComponentButton.OnClick(ClickEvent e)
2022-04-06 18:32:24 [error]: at System.Linq.Enumerable.TryGetFirst[TSource](IEnumerable`1 source, Func`2 predicate, Boolean& found)
2022-04-06 18:32:24 [error]: at osu.Framework.Input.ButtonEventManager`1.PropagateButtonEvent(IEnumerable`1 drawables, UIEvent e)
2022-04-06 18:32:24 [error]: at osu.Framework.Input.MouseButtonEventManager.handleClick(InputState state, List`1 targets)
2022-04-06 18:32:24 [error]: at osu.Framework.Input.MouseButtonEventManager.HandleButtonUp(InputState state, List`1 targets)
2022-04-06 18:32:24 [error]: at osu.Framework.Input.InputManager.HandleMouseButtonStateChange(ButtonStateChangeEvent`1 e)
2022-04-06 18:32:24 [error]: at osu.Framework.Input.UserInputManager.HandleInputStateChange(InputStateChangeEvent inputStateChange)
2022-04-06 18:32:24 [error]: at osu.Framework.Input.StateChanges.ButtonInput`1.Apply(InputState state, IInputStateChangeHandler handler)
2022-04-06 18:32:24 [error]: at osu.Framework.Input.InputManager.Update()
2022-04-06 18:32:24 [error]: at osu.Framework.Input.PassThroughInputManager.Update()
2022-04-06 18:32:24 [error]: at osu.Framework.Graphics.Drawable.UpdateSubTree()
2022-04-06 18:32:24 [error]: at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
2022-04-06 18:32:24 [error]: at osu.Framework.Platform.GameHost.UpdateFrame()
2022-04-06 18:32:24 [error]: at osu.Framework.Threading.GameThread.processFrame()
2022-04-06 18:32:24 [verbose]: Unhandled exception has been allowed with 0 more allowable exceptions .

Log on latest update (2022.405.0) :
runtime.log

Since the log is not show much different when can reproduce error and cannot reproduce error. So I try to reproduce it in debug mode by just start fetch master branch, restore nuget, running the project in Rider and reproduce it and here is the full log on debug mode :
runtime.log

Screen record on reproduce this bug on debug mode :

2022-04-07.02-23-37.mp4

Since I'm not sure on how to fully reproduce the bug or is there any duplicate issues on this but if this is a bug it's more of a reliability type (since no one do that) so I just post it on discussion and if it's not duplicate so you can escalate it to the real issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants