Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom osu-stable install path lookup #1907

Closed
Stoxmel opened this issue Jan 15, 2018 · 12 comments
Closed

Add support for custom osu-stable install path lookup #1907

Stoxmel opened this issue Jan 15, 2018 · 12 comments
Labels
priority:3 Nice to have, at some point

Comments

@Stoxmel
Copy link

Stoxmel commented Jan 15, 2018

As the title says, that is the only message I get, when clicking on import beatmaps.
Yes, I have osu!stable version installed. And sorry if there was already a post about this, but I did not find one.

Taken from the database.log:

15.01.2018 05:31:12: Failed executing DbCommand (11ms) [Parameters=[], CommandType='Text', CommandTimeout='10']
15.01.2018 05:31:12: SELECT MetadataID FROM BeatmapSetInfo LIMIT 1
15.01.2018 05:31:12: Performing migration from sqlite-net to EF...
15.01.2018 05:31:12: Failed executing DbCommand (0ms) [Parameters=[], CommandType='Text', CommandTimeout='10']
15.01.2018 05:31:12: INSERT INTO RulesetInfo SELECT ID, Available, InstantiationInfo, Name FROM RulesetInfo_Old
15.01.2018 05:31:12: Migration failed! We'll be starting with a fresh database.
15.01.2018 05:31:12: Microsoft.Data.Sqlite.SqliteException (0x80004005): SQLite Error 1: 'table RulesetInfo has 5 columns but 4 values were supplied'.
15.01.2018 05:31:12: bei Microsoft.Data.Sqlite.SqliteException.ThrowExceptionForRC(Int32 rc, sqlite3 db)
15.01.2018 05:31:12: bei Microsoft.Data.Sqlite.SqliteCommand.ExecuteReader(CommandBehavior behavior)
15.01.2018 05:31:12: bei Microsoft.Data.Sqlite.SqliteCommand.ExecuteNonQuery()
15.01.2018 05:31:12: bei Microsoft.EntityFrameworkCore.Storage.Internal.RelationalCommand.Execute(IRelationalConnection connection, DbCommandMethod executeMethod, IReadOnlyDictionary2 parameterValues) 15.01.2018 05:31:12: bei Microsoft.EntityFrameworkCore.Storage.Internal.RelationalCommand.ExecuteNonQuery(IRelationalConnection connection, IReadOnlyDictionary2 parameterValues)
15.01.2018 05:31:12: bei Microsoft.EntityFrameworkCore.RelationalDatabaseFacadeExtensions.ExecuteSqlCommand(DatabaseFacade databaseFacade, RawSqlString sql, IEnumerable`1 parameters)
15.01.2018 05:31:12: bei Microsoft.EntityFrameworkCore.RelationalDatabaseFacadeExtensions.ExecuteSqlCommand(DatabaseFacade databaseFacade, RawSqlString sql, Object[] parameters)
15.01.2018 05:31:12: bei osu.Game.Database.OsuDbContext.migrateFromSqliteNet()
15.01.2018 05:31:12: Database purged successfully.
15.01.2018 05:31:12: Failed executing DbCommand (2ms) [Parameters=[], CommandType='Text', CommandTimeout='10']
15.01.2018 05:31:12: SELECT MetadataID FROM BeatmapSetInfo LIMIT 1
15.01.2018 05:31:12: Failed executing DbCommand (0ms) [Parameters=[], CommandType='Text', CommandTimeout='10']
15.01.2018 05:31:12: SELECT OnlineBeatmapSetId FROM BeatmapMetadata LIMIT 1

can attach the log, too, if that would be more helpful.

@Aergwyn
Copy link
Member

Aergwyn commented Jan 15, 2018

Can you show the runtime log too? That may contain a bit more info about what happened hopefully.

@Stoxmel
Copy link
Author

Stoxmel commented Jan 15, 2018

runtime.log

attached the log!

@Aergwyn
Copy link
Member

Aergwyn commented Jan 15, 2018

Was by any chance your previous lazer version really old before you updated? Failing migration to EF looks weird. I'd delete the database (look in %APPDATA%/osu or with ingame settings open osu folder button) and then try again and see if it still happens.

@Stoxmel
Copy link
Author

Stoxmel commented Jan 15, 2018

I just installed osu!lazer, I tried to delete the database, but I still get the same error message

@peppy
Copy link
Sponsor Member

peppy commented Jan 15, 2018

The failure is an expected failure (it's an exception on purpose).

@Stoxmel
Copy link
Author

Stoxmel commented Jan 15, 2018

Why is that an expected failure? Is there still a way?

@peppy
Copy link
Sponsor Member

peppy commented Jan 15, 2018

You can implement custom path support for stable lookups, or wait until it's implemented.

@Stoxmel
Copy link
Author

Stoxmel commented Jan 15, 2018

So actually editing the source code itself?

@peppy
Copy link
Sponsor Member

peppy commented Jan 15, 2018

osu!lazer is currently in early stages of development and is not yet ready for end users. We encourage contributions or patience.

@Stoxmel
Copy link
Author

Stoxmel commented Jan 15, 2018

Well, I think I have to wait then, but thanks for the response!

@peppy peppy changed the title Issue while importing beatmaps from stable - "No osu!stable installation available" Add support for custom osu-stable install path lookup Jan 15, 2018
@peppy
Copy link
Sponsor Member

peppy commented Jan 15, 2018

I'll leave this issue open with a new name, since it doesn't exist yet. Probably only needs to be added for windows, using a registry lookup to find the most recent osu! install path.

@peppy
Copy link
Sponsor Member

peppy commented Feb 18, 2021

#11603

@peppy peppy closed this as completed Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:3 Nice to have, at some point
Projects
None yet
Development

No branches or pull requests

4 participants