Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poor osu!mania editor performance #20596

Open
hburn7 opened this issue Oct 6, 2022 · 3 comments
Open

Poor osu!mania editor performance #20596

hburn7 opened this issue Oct 6, 2022 · 3 comments
Labels
area:editor priority:2 Moderately important. Relied on by some users or impeding the usability of the game ruleset/osu!mania type:performance

Comments

@hburn7
Copy link

hburn7 commented Oct 6, 2022

Type

Performance

Bug description

The osu!Mania editor, at least on my particular machine which runs Apple Silicon, is very laggy and causes multi-second freezes when scrubbing. The system is a MacBook Pro 16-inch 2021 model with the Apple M1 Pro chip.

Screenshots or videos

lag-compressed.mp4

Version

2022.923.1

Logs

database.log
network.log
performance.log
runtime.log

@peppy peppy changed the title Poor osu!Mania editor performance on Apple Silicon Poor osu!mania editor performance Oct 7, 2022
@peppy
Copy link
Sponsor Member

peppy commented Oct 7, 2022

Could you please link the beatmap you were testing with?

@hburn7
Copy link
Author

hburn7 commented Oct 7, 2022

Sure thing. Here you go https://osu.ppy.sh/beatmapsets/1084004#mania/2267036

@ekrctb
Copy link
Collaborator

ekrctb commented Oct 7, 2022

A lag for a seek is same as #20221.
Later sustained frame rate drop is probably because

if (LifetimeEnd == double.MaxValue && (state.Value != ArmedState.Idle || HitObject.HitWindows == null))
LifetimeEnd = Math.Max(LatestTransformEndTime, HitStateUpdateTime + (Samples?.Length ?? 0));

getting skipped and hit object lifetime never ends.

@peppy peppy added type:performance ruleset/osu!mania priority:2 Moderately important. Relied on by some users or impeding the usability of the game labels Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editor priority:2 Moderately important. Relied on by some users or impeding the usability of the game ruleset/osu!mania type:performance
Projects
None yet
Development

No branches or pull requests

3 participants