Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mania hold notes that generate hold ticks inside their hit/release window can lead to unexpected combobreaks #24584

Closed
Bruno5430 opened this issue Aug 18, 2023 · 1 comment · Fixed by #25062
Assignees
Labels
area:gameplay compatibility change Changes to be considered in the future which break compatibility with osu!stable scores. ruleset/osu!mania

Comments

@Bruno5430
Copy link

Type

Game behaviour

Bug description

I found some beatmaps that have a lot of hold ticks, and some of those ticks conflicts with the hit/release window of the hold note

In stable (with scoreV1), you can miss hold ticks without combobreaking if the hold tick was inside of the release window of the note
(you can see proof of this by looking at most of the leaderborads of stable where the maximum combo varies across the top 50 scores. Example: https://osu.ppy.sh/beatmapsets/400078#mania/992512)

But in lazer, missing ticks will always make you combobreak even if it's inside of either the hit or release window of the note

Screenshots or videos

(Loved) sakuraburst - data corruption symphony [ASPIRE_advanced]
replay.zip

Clearly way too much hold ticks, releasing the hold note "great early" results in a combobreak

2023-08-17.15-35-18.webm

(Graveyard) DJ Noriken & aran - Comet Coaster [<JUMP!! ~LN Special~]
replay.zip

Releasing the hold note early in the 3rd column at 8 seconds of drain time results in a combobreak, even if it isn't judged as a miss

2023-08-17.15-34-35.webm

(Ranked) Camellia - M1LLI0N PP [DOM1NATI0N]
replay.zip

Some hold notes have a hold tick right after their head on the "LN trill" sections of the beatmap, and hitting them "good late" results in a combobreak

2023-08-18.15-05-21.webm

Version

2023.815.0

Logs

@bdach bdach added ruleset/osu!mania area:gameplay compatibility change Changes to be considered in the future which break compatibility with osu!stable scores. labels Aug 19, 2023
@smoogipoo smoogipoo self-assigned this Aug 21, 2023
@bdach
Copy link
Collaborator

bdach commented Sep 11, 2023

@smoogipoo given #24618 (i.e. ticks will not be a thing) I'm moving this to "needs implementation" because I don't think there's anything left to discuss if we're removing ticks because that sounds like definitively fixing the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:gameplay compatibility change Changes to be considered in the future which break compatibility with osu!stable scores. ruleset/osu!mania
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants