Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-Touch Tablet automaticly gets detected as Touch device #25590

Closed
Coocys opened this issue Nov 27, 2023 · 10 comments · Fixed by ppy/osu-framework#5309
Closed

Non-Touch Tablet automaticly gets detected as Touch device #25590

Coocys opened this issue Nov 27, 2023 · 10 comments · Fixed by ppy/osu-framework#5309

Comments

@Coocys
Copy link

Coocys commented Nov 27, 2023

Type

Game behaviour

Bug description

I use an XP-PEN Artist 15.6 and every of my plays get flagged with the touch device mod. But the version of my tablet has no touch capability's.
It doesn't matter if I select the beatmap with mouse or tablet the score still gets the mod.
To add to this I am not even a drag player I just hover over my tablet.

Screenshots or videos

https://github.com/ppy/osu/assets/52206546/5a7ed8b3-be4a-4cf2-8966-3d454106612c
This shows if I drag or select anything with my tablet pen it applies the mod

https://github.com/ppy/osu/assets/52206546/5beb502f-a0f0-4542-89b2-9917b8e4c21f
Here I select the song with my mouse but it still applies the mod afterwards if I use my tablet in any extend

Version

2023.1114.1-lazer

Logs

performance.log
runtime.log
updater.log
database.log
input.log
network.log

@dsal08
Copy link

dsal08 commented Nov 29, 2023

I just had this problem problem what I did to fix it was going into the Wacom drivers and change the settings to where when you touch the pen down to the tablet it doesn’t count as a click like for a mouse and that fix the problem for me

@LillyLeafy
Copy link

New to using github so I hope this is alright, but I'm having the exact same issue with my old "Huion H420".

@Coocys
Copy link
Author

Coocys commented Nov 30, 2023

I just had this problem problem what I did to fix it was going into the Wacom drivers and change the settings to where when you touch the pen down to the tablet it doesn’t count as a click like for a mouse and that fix the problem for me

I do not use the original Wacom driver because they led to problems with my system. That is why I use OpenTabletDriver.

I would have another suggestion for the solution of the problem. I usually play without klick input in osu!standard if that is active it should be irrelevant if I use a "Touch Device" or is it?

@Epicguru
Copy link

Epicguru commented Dec 1, 2023

Second this. CTL-472 detected as a touch device, using OpenTabletDriver with Wacom drivers disabled, Tablet mode disabled in-game. Attempting to disable Touch mode in-game makes every input be detected as a 'click' or 'drag' which makes the game unplayable.

It looks like some part of #25348 is not working as intended.

@bdach
Copy link
Collaborator

bdach commented Dec 1, 2023

No it's most likely either an upstream bug in SDL or the tablets involved are reporting weird events which get mistaken by SDL / input layer to be touches. I can't say for sure because I own none of the hardware. But at this point we're probably going to have to port the stable heuristic algorithm across instead because obviously there are too many complaints that the touch detection does not work exactly like stable.

@Coocys
Copy link
Author

Coocys commented Dec 1, 2023

Is there any way we can help to fix this? Because obviously we own the devices that led to the problem and could provide any info you need.

@bdach
Copy link
Collaborator

bdach commented Dec 1, 2023

If you are able, you could try running the game with the SDL_EVENT_LOGGING=1 environment variable set, then click around to trigger the touch input detection, and then attach runtime.log from that execution. That could confirm what the device is reporting. Unless the in-game opentabletdriver interferes.

You could try messing with that too actually I guess. See if disabling/enabling in-game OTD fixes this or not.

But none of that changes the fact we're probably porting stable's detection across anyway, as people are complaining that players that use touchscreens in ways that technically do not make the game easier are getting unfairly nerfed by touch detection relying on the hardware reports.

@Coocys
Copy link
Author

Coocys commented Dec 1, 2023

I still tested around with the build in OTD.
It fixed it for me that means when I turn of the OTD on my pc and use the build in OTD the mod does not get applied.

If I find the time I try to log it with the OTD from my pc. But I am not sure how long that will take due to time and knowledge how env variable works and how I run osu with it.

@Susko3
Copy link
Member

Susko3 commented Dec 4, 2023

Known issue with windows ink: #5378 (comment).
A fix is pending in ppy/osu-framework#5309, but it requires a change that has been merged to SDL3, but not SDL2. I guess we could change to use our fork of SDL2 again, or just do a one-off build with the change cherry-picked.

@peppy
Copy link
Sponsor Member

peppy commented Dec 5, 2023

Might be best to backport ourselves if SDL are not going to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants