Game does not prevent fail on banana showers

[spdragon0]

Type

Game behaviour

Bug description

In osu!catch, the player can fail when their HP reaches 0 during a banana shower. In stable this does not happen.
Edit: for clarification, I recorded both tests outside of the editor. I also fixed the embed issue (first video is osu!lazer, second video is osu!stable).

Screenshots or videos

simplescreenrecorder-2024-02-10_13.21.06.mp4

2024-02-10.15-47-16.mp4

Version

2024.130.2-lazer

Logs

1707593424.input.log
1707593424.network.log
1707593424.performance.log
1707593424.runtime.log

[bdach]

@ppy/team-client not sure what to make of this. do we wanna preserve this behaviour? i worry that it's going to cause even more ruleset-specific mess because i'm not super sure our health processor structure is well-equipped to handle this.

[smoogipoo]

Yeah it should be preserved. I think it's as easy as excluding bonus judgements from running the check in HealthProcessor.

[spdragon0]

I updated to 2024.312.0 and played Broken Hearts (https://osu.ppy.sh/beatmapsets/2136340); it still fails somehow, though only right before/after(?) the next fruit. I haven't tried with tiny droplets.

osu-bananafail.mp4

[bdach]

@spdragon0 do you have a replay for this?

also am I seeing correct that that map has normal fruits during a banana shower? I'm not sure we're gonna support that...

[spdragon0]

Here's the exported replay:
poi4 playing eFeL - Broken Hearts (Razor Sharp) [Shattered Stars] (2024-03-11_14-34).zip
This map was ranked a few days ago.

Edit: I checked in the editor and did an autoplay, it doesn't look like any of the fruits and spinners (banana showers) are overlapping.

[spdragon0]

Okay, I found the cause of the new failure at 0 HP:
It happens at the tail end of the banana shower, so it's right before I catch the next fruit (which is why the replay shows 24 max combo instead of 25).
Edit: video added

osu-bananafail2.mp4

[bdach]

@spdragon0 thanks, this should be fixed next release by #27677.