Fix draining processor failing gameplay on bonus misses, tiny droplet misses, and ignore hits

[bdach]

This closes:

• Game does not prevent fail on banana showers #27121
• Missing droplets with depleted HP can cause the player to fail #27159
• Another untracked case is spinners in osu! - if you clear a spinner but leave any unjudged bonus ticks, and in the meantime health drops to zero, then gameplay will fail while it shouldn't.

The "ignore hit" portion of this is a small carve-out for another weird detail I found along the way wherein IgnoreHits would cause the health processor to invoke failure even though they're successful hits, and this is because they do not give any health gain. You could ask why that's not a MaxHealthIncrease > 0 check instead - it's not because it breaks the other added test cases, in particular things like a ComboBreak which has an IgnoreHit max judgement but also should cause failure at zero HP.

I'll readily admit that I didn't empirically test this in catch because I'm not good enough at the mode / couldn't find a good beatmap to test on. But I did test the osu! case manually.

For reference: stable code for osu! and for catch.

Please read the test cases for the desired behaviour here.

[bdach]

blocking because apparently #27159 is a thing too and i don't think this pull fixes this (but it should)

[bdach]

This fixes #27159 now too. See inline comment for explanation.

Can be manually tested using test.zip (change extension to .osz to import). To test, miss the first fruit and two subsequent large droplets, then hit every large droplet / fruit until the end of the map but move out of the way inbetween so that small droplets get missed. You should be able to hit zero hp pretty easily.

[bdach]

Of course perfect mod breaks this. Missing a tiny droplet with nomod can't fail on stable, but with perfect on it can.

I don't even know at this point.

[bdach]

Maybe fixed. Rationale in last commit message. Now this has infinity percent more breaking ruleset API changes but I'm not sure how to fix otherwise.

[smoogipoo]

lgtm

[smoogipoo]

Do you remember if there any particular cases (aside from test failures) that informed your decision to not include IgnoreMiss here? Looking at #27121 (comment)

It sounds like there's two solutions:

1. Make DrawableBananaShower indicate IgnoreHit at all times.
2. Change the base condition to also include IgnoreMiss. At face value this doesn't sound too extreme to me. The alternative is ... || Type == IgnoreHit || (Judgement.Max == IgnoreHit && Type == IgnoreMiss) i.e. the special IgnoreJudgement.

[bdach]

if there any particular cases (aside from test failures) that informed your decision to not include IgnoreMiss here?

Probably the biggest one is osu! slider tail circle which uses (SliderTailHit, IgnoreMiss) when classic mod is off. That should probably allow failure still.